refactor: Explain feature icon to match brand guidelines and update link press handling by samranahm · Pull Request #83169 · Expensify/App

samranahm · 2026-02-22T21:21:38Z

Explanation of Change

Fixed Issues

$ #82171
PROPOSAL: N/A

Tests

Open a Workspace expense chat.
Create an expense with a known merchant (e.g., Starbucks) and leave the Category field empty.
Wait for Concierge to automatically add the category and post a “set category based on past activity…” message.
Verify that the Explain link with the branded icon (available in OP) appears in the message.
Press the Explain link and verify that a message is posted in the thread.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Native.mp4

Android: mWeb Chrome

Android.mWeb.Chrome.mp4

iOS: Native

IOS.Native.mp4

iOS: mWeb Safari

IOS.mWeb.Safari.mp4

MacOS: Chrome / Safari

macOS.Chrome.mp4

melvin-bot · 2026-02-22T21:21:44Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Copilot

Pull request overview

This PR updates the Explain feature in automated Concierge messages to use a branded Sparkles icon instead of a sparkle emoji, removes bold formatting from the link text, and refactors the link press handling from HTML-based to component-based implementation.

Changes:

Replaced HTML-based rendering with component-based approach using TextBlock, TextLinkBlock, and Icon components
Added new Sparkles SVG icon asset and integrated it into the Expensify icons chunk
Added "explain" translation key across all supported languages and removed the old "AskToExplain" HTML-based translation
Added new mr0half spacing utility for 2px right margin

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx	Refactored from HTML-based to component-based rendering with TextBlock, TextLinkBlock, and Icon; replaced link handler logic
src/styles/utils/spacing.ts	Added `mr0half` utility for 2px right margin spacing
assets/images/sparkles.svg	Added new branded Sparkles icon SVG
src/components/Icon/chunks/expensify-icons.chunk.ts	Imported and exported new Sparkles icon
src/languages/*.ts (10 files)	Added `common.explain` translation and removed `iou.AskToExplain` HTML-based translation across all languages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1ee238f9d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx

codecov · 2026-02-22T22:40:57Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...nbox/report/ReportActionItemMessageWithExplain.tsx	`33.33% <30.76%> (-66.67%)`	⬇️
... and 14 files with indirect coverage changes

dubielzyk-expensify · 2026-02-23T00:22:05Z

Can we see dark mode too just to check? Looking good to me though

samranahm · 2026-02-23T11:38:18Z

Here we go..

JmillsExpensify

No concerns with product behavior.

shawnborton · 2026-02-23T13:37:18Z

Screenshots look correct to me 👍

dannymcclain · 2026-02-23T13:37:32Z

Looking good to me too 👍

FitseTLT · 2026-02-24T21:32:39Z

I can take over based on https://expensify.slack.com/archives/C02NK2DQWUX/p1771968690980059

FitseTLT · 2026-02-24T21:40:00Z

@samranahm pls merge main

samranahm · 2026-02-24T21:50:51Z

Resolving merge conflicts.

…ture-icon

samranahm · 2026-02-24T21:56:10Z

@FitseTLT All yours.

samranahm · 2026-02-24T22:06:15Z

Failing typecheck not related to this PR. #83234 (comment)

src/styles/utils/spacing.ts

src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx

…n-feature-icon

FitseTLT · 2026-02-26T22:17:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

FitseTLT · 2026-02-27T15:09:24Z

Resolve conflicts @samranahm

…ture-icon

src/languages/nl.ts

-            billable: (value: boolean) => (value ? 'heeft de uitgave gemarkeerd als ‘door te belasten’' : 'heeft de uitgave gemarkeerd als ‘niet factureerbaar’'),
+        correctRateError: 'Los de tarieffout op en probeer het opnieuw.',
+        duplicateNonDefaultWorkspacePerDiemError: 'Je kunt dagvergoedingen niet dupliceren tussen werkruimtes, omdat de tarieven per werkruimte kunnen verschillen.',
+        rulesModifiedFields: {


FitseTLT

LGTM

FitseTLT · 2026-02-27T17:23:07Z

@marcaaron U can proceed

marcaaron

Woo! Looks great to me 🙇 Thanks everyone for their patience in figuring this out. Feel like we struck a good balance here.

OSBotify · 2026-02-27T19:40:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-27T19:41:46Z

🚧 @marcaaron has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-27T19:46:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83169.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2f89e0d-7ab88ad-73660a876eb9e736bcb51e8cd950b81891ee8841/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2f89e0d-7ab88ad-532b33f98d9195d4d66b2597f1153dca0075940e/index.html

Web 🕸️
https://83169.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

samranahm added 4 commits February 23, 2026 01:55

Add Sparkles icon to ExpensifyIcons

365aab9

update copies in all locals

6590c3f

refactor ReportActionItemMessageWithExplain component

3beef1f

add mr0half in spacing

a1ee238

Copilot AI review requested due to automatic review settings February 22, 2026 21:21

samranahm requested review from a team as code owners February 22, 2026 21:21

melvin-bot bot assigned samranahm Feb 22, 2026

melvin-bot bot requested review from JmillsExpensify and ikevin127 February 22, 2026 21:21

Copilot started reviewing on behalf of samranahm February 22, 2026 21:22 View session

samranahm mentioned this pull request Feb 22, 2026

[$250] Update Explain feature icon to match brand guidelines #82171

Open

Copilot AI reviewed Feb 22, 2026

View reviewed changes

src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 22, 2026

View reviewed changes

src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx Show resolved Hide resolved

fix failing checks

29d092b

JmillsExpensify previously approved these changes Feb 23, 2026

View reviewed changes

samranahm added 2 commits February 25, 2026 02:53

remove Sparkles icon

9c4a325

Merge remote-tracking branch 'upstream' into 82171/Update-explain-fea…

ad5529e

…ture-icon

samranahm dismissed JmillsExpensify’s stale review via ad5529e February 24, 2026 21:55

FitseTLT reviewed Feb 25, 2026

View reviewed changes

src/styles/utils/spacing.ts Outdated Show resolved Hide resolved

src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx Outdated Show resolved Hide resolved

src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx Show resolved Hide resolved

samranahm added 3 commits February 26, 2026 19:35

Merge remote-tracking branch 'upstream/main' into 82171/Update-explai…

81576f7

…n-feature-icon

apply review suggestions

99f9c6f

fiix spell check

56a1711

Merge remote-tracking branch 'upstream' into 82171/Update-explain-fea…

3cd1ddf

…ture-icon

FitseTLT reviewed Feb 27, 2026

View reviewed changes

FitseTLT approved these changes Feb 27, 2026

View reviewed changes

melvin-bot bot requested a review from marcaaron February 27, 2026 17:22

marcaaron approved these changes Feb 27, 2026

View reviewed changes

marcaaron merged commit 2f89e0d into Expensify:main Feb 27, 2026
32 checks passed

Conversation

samranahm commented Feb 22, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Feb 22, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dubielzyk-expensify commented Feb 23, 2026

Uh oh!

samranahm commented Feb 23, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Feb 23, 2026

Uh oh!

dannymcclain commented Feb 23, 2026

Uh oh!

FitseTLT commented Feb 24, 2026

Uh oh!

FitseTLT commented Feb 24, 2026

Uh oh!

samranahm commented Feb 24, 2026

Uh oh!

samranahm commented Feb 24, 2026

Uh oh!

samranahm commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FitseTLT commented Feb 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT commented Feb 27, 2026

Uh oh!

This comment was marked as off-topic.

Uh oh!

FitseTLT left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Feb 27, 2026

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

codecov bot commented Feb 22, 2026 •

edited by github-actions bot

Loading