Add microsecond timeouts to bedrock client #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodnv
approved these changes
Jun 11, 2025
| * string clusterName Name of the bedrock cluster. This is used to separate requests made to different bedrock clusters. | ||
| * array|null mainHostConfigs List of hosts to attempt first | ||
| * array|null failovers List of hosts to use as failovers | ||
| * int|null connectionTimeout Timeout to use when connecting |
Contributor
There was a problem hiding this comment.
Can we remove this after the transition period?
Contributor
Author
There was a problem hiding this comment.
I'll do some tests to see if you can pass a timeout of several seconds in the useconds param or if it is just for the subsecond part of the timeout.
Contributor
Author
There was a problem hiding this comment.
Could not test https://github.com/Expensify/Web-Expensify/pull/47169#issuecomment-2966170884
We can probably leave this anyway
| * array|null failovers List of hosts to use as failovers | ||
| * int|null connectionTimeout Timeout to use when connecting | ||
| * int|null connectionTimeoutMicroseconds Microsecond timeout to use when connecting | ||
| * int|null readTimeout Timeout to use when reading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for https://github.com/Expensify/Expensify/issues/509923
Used in https://github.com/Expensify/Web-Expensify/pull/47169