Gracefully handle EINPROGRESS #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flodnv
commented
Jul 31, 2025
flodnv
commented
iwiznia
reviewed
Jul 31, 2025
| } | ||
|
|
||
| // Check if connection completed successfully | ||
| $connectionError = socket_get_option($this->socket, SOL_SOCKET, SO_ERROR); |
Contributor
There was a problem hiding this comment.
Not sure I get this, wouldn't socket_select already return an error and that should be handled above?
Contributor
Author
There was a problem hiding this comment.
This all sounds right to me 🤔
Contributor
There was a problem hiding this comment.
ok not sure really, but we can try it
iwiznia
reviewed
Jul 31, 2025
| $read = null; | ||
| $except = null; | ||
|
|
||
| $selectResult = socket_select($read, $write, $except, $this->connectionTimeout, $this->connectionTimeoutMicroseconds); |
Contributor
There was a problem hiding this comment.
Not that it matters much, but this would basically double the timeout (since we would wait for the timeout in socket_connect and then again here.
Contributor
Author
There was a problem hiding this comment.
I think that's fine if we lower the timeout to 500ms, which I'll do
iwiznia
previously approved these changes
Aug 4, 2025
Contributor
Author
|
Version created |
iwiznia
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.