Skip to content

Save commitCount when response says to #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2025
Merged

Save commitCount when response says to #232

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfb81c7
Save commitCount when response says to
neil-marcellini Sep 1, 2025
7348afc
Fix phan
neil-marcellini Sep 2, 2025
9c6824f
Clean up comment per feedback
neil-marcellini Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,12 +703,11 @@ private function receiveResponse()
}
} while (is_null($responseLength) || strlen($response) < $responseLength);

// We save the commitCount for future requests. This is useful if for some reason we change the bedrock node we
// are talking to.
// We only set it if process time was returned, which means we did a write. We don't care about saving the commit
// count for reads, since we did not change anything in the DB.
if (isset($responseHeaders['commitCount']) && (($responseHeaders['processTime'] ?? 0) > 0 || ($responseHeaders['upstreamProcessTime'] ?? 0) > 0)) {
$this->commitCount = (int) $responseHeaders['commitCount'];
// Save the commit count if needed.
// In some cases, Auth will return a header instructing the client to save the commit count. It is useful for determining if stale data was used for certain read commands.
// Commit counts are saved for all write commands, identified by process time being non-zero, because it can be useful for future requests if for some reason we change the bedrock node we are talking to.
if ($responseHeaders['shouldSaveCommitCount'] ?? false || (isset($responseHeaders['commitCount']) && (($responseHeaders['processTime'] ?? 0) > 0 || ($responseHeaders['upstreamProcessTime'] ?? 0) > 0))) {
$this->commitCount = (int) ($responseHeaders['commitCount'] ?? 0);
}

// We treat this '555 Timeout', which is a command timeout (not a query timeout), as a ConnectionFailure so that it gets retried regardless of if it is idempotent or not.
Expand Down