Skip to content

fix: update currentlyFocusedNode on focus #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

truph01
Copy link
Contributor

@truph01 truph01 commented May 20, 2025

Details

  • This PR implements the solution described in this proposal, combined with this suggestion.
  • It attempts to update the _currentlyFocusedNode when the markdown text input receives focus.

Related Issues

Expensify/App#61521

Manual Tests

  1. Go to ND
  2. Login account with more chats
  3. Tap search
  4. Scroll the page up and down
  5. Verify: In search, scrolling the page must close the keypad.

Linked PRs

Result:

Screen.Recording.2025-05-20.at.17.58.29.mov

Copy link

github-actions bot commented May 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@truph01
Copy link
Contributor Author

truph01 commented May 20, 2025

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some checks fail, please fix lint errors

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@parasharrajat
Copy link
Member

@Skalakid Let's get this merged. Thanks.

@Skalakid Skalakid merged commit ead1df3 into Expensify:main May 26, 2025
5 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented May 26, 2025

🚀 Published to npm in 0.1.277 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants