fix multiline breaking links #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
fix multiline breaking blockquote
jmusial
force-pushed
the
fix/multiline-issues-on-web
branch
from
37f898a to
a3f9ca7
Compare
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
May 23, 2025
This is a really cool finding. Does this give us some more opportunities to simplify our code in other places as well? Also, could you please upload some screen recordings showing how it worked before and how it works after the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiline breaking blockquote
Fix multiline breaking links underline
Details
Links underline
There is another fix possible
With link text staying
vertical-align: middleand just pushing the underline lower.Not sure which one is prefereable.
Blockquote
Turns out when we have
white-space: nowrapcontentEditable changes spaces to non-breaking (ASCII 160 vs normal 32). This is the simplest fix. Alternative is to replace them in the event or makeExpensiMarkrecognize them as spaces. Again, not sure which one is preferable.Related Issues
#548
Videos
Before
LM_multiline_before.mov
After
LM_multiline_after.mov
Manual Tests
Links underline
Blockquote
blockquote(>)Linked PRs