Skip to content

Conversation

luacmartins
Copy link
Contributor

Details

Coming from this thread, we added provenance to the npm publish workflow, so we need to make sure the repo URL matches what npm expects

What this fixes

https://expensify.slack.com/archives/C06BDSWLDPB/p1739793644035839

@luacmartins luacmartins self-assigned this Feb 18, 2025
Copy link

github-actions bot commented Feb 18, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@luacmartins
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Feb 18, 2025
@luacmartins
Copy link
Contributor Author

hmm it seems like npm still has the old URLs for this repo - https://www.npmjs.com/package/react-native-qrcode-svg

Copy link
Contributor

@Kicu Kicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably also should change it in lines 52 and 50.

Yeah this link on npm never got changed after the transfer of ownership. Perhaps if we publish a version with updated package.json then npm info will get updated? 🤔

@luacmartins luacmartins requested a review from Kicu February 19, 2025 17:29
@luacmartins
Copy link
Contributor Author

Updated!

Copy link
Contributor

@Kicu Kicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roryabraham roryabraham merged commit 82e091b into main Feb 21, 2025
1 check passed
@os-botify
Copy link
Contributor

os-botify bot commented Feb 21, 2025

🚀 Published to npm in 6.3.15 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants