-
Notifications
You must be signed in to change notification settings - Fork 224
Fix repo url #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repo url #236
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
hmm it seems like npm still has the old URLs for this repo - https://www.npmjs.com/package/react-native-qrcode-svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably also should change it in lines 52 and 50.
Yeah this link on npm never got changed after the transfer of ownership. Perhaps if we publish a version with updated package.json then npm info will get updated? 🤔
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Details
Coming from this thread, we added provenance to the
npm publish
workflow, so we need to make sure the repo URL matches what npm expectsWhat this fixes
https://expensify.slack.com/archives/C06BDSWLDPB/p1739793644035839