Ping not executed

[dennisvang]

Running the latest develop branch (8eaffbb) from source, necessarily using the development profile.

If we configure ping.enabled=true, a ping is scheduled, but not executed.

For example, with the following settings in application.yml:

ping:
  enabled: true
  interval: 5000  # ms

or the equivalent in environment variables, e.g. PING_ENABLED=true;PING_INTERVAL=5000.

For v1.17 this works (or at least tries to execute the ping), but for develop nothing happens...

[dennisvang]

The problem (or at least one of the problems) is that settings.getPingEnabled() returns false despite the fact that we specified ping.enabled=true:

FAIRDataPoint/src/main/java/org/fairdatapoint/service/ping/PingService.java

Lines 60 to 61 in 8eaffbb

	final Settings settings = settingsService.getOrDefaults();
	if (!settings.getPingEnabled() || !pingProperties.isEnabled()) {

where settingsService.getOrDefaults() calls settingsCache.getOrDefaults().

For some reason, pingEnabled in the settings cache remains false.

So probably the cache is not being updated?

The configuration settings do appear to be stored correctly in the database:

[dennisvang]

As we're running the development profile, it looks like the defaults from the dev db are picked up, and these are not overridden by the configuration from either application*.yml or environment variables:

FAIRDataPoint/src/main/java/org/fairdatapoint/service/settings/SettingsCache.java

Lines 51 to 57 in 8eaffbb

	@PostConstruct
	public void updateCachedSettings() {
	updateCachedSettings(
	settingsRepository
	.findByUuid(KnownUUIDs.SETTINGS_UUID)
	.orElse(settingsDefaults.getDefaults())
	);

Note the @PostConstruct.

These are the defaults from the database:

FAIRDataPoint/src/main/resources/dev/db/migration/V0001.5__dev-settings.sql

Line 26 in 8eaffbb

VALUES ('00000000-0000-0000-0000-000000000000', 'FAIR Data Point', 'FDP Development Instance', False, ARRAY ['https://home.fairdatapoint.org'], True, now(), now());

As a quick test, temporarily skipping the settings migration file does fix the issue: the configuration from PingProperties is picked up and the ping task is then executed (which then fails due to #645, but that's another matter).

So, the fact that pings are not executed at all is probably by design, because configuration settings from the database should (I assume) override those defined at application start.

However, there does seem to be a mismatch between the settings displayed in the client and the ones actually active in the settings cache, as can be seen above: the fdp acts upon the pingEnabled value from the cache, which is initialized from the database (in this case), but the client appears to show the values from the configuration (e.g. from PingProperties)...

This is expected for the ping interval

FAIRDataPoint/src/main/java/org/fairdatapoint/service/ping/PingService.java

Line 57 in 8eaffbb

fixedRateString = "${ping.interval:P7D}"

but the ping enabled setting should be obtained from the cache.

Moreover, toggling the "enabled" setting in the client settings view, and saving, multiple times, does not appear to have an effect.