Align TextFlowExt with future getLayoutInfo #1246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jugen
force-pushed
the
Align-TextFlowExt-with-future-getLayoutInfo
branch
from
f6cf09c to
87b874e
Compare
4 tasks
|
Thank you @Jugen for verifying early versions of the API! Please keep in mind that the API might also change during the review process. Hope it gets into jfx24, but no guarantees. Feel free to comment in openjdk/jfx#1596 |
Jugen
force-pushed
the
Align-TextFlowExt-with-future-getLayoutInfo
branch
2 times, most recently
from
98ac9eb to
db0c478
Compare
Jugen
force-pushed
the
Align-TextFlowExt-with-future-getLayoutInfo
branch
from
db0c478 to
5054a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
TextFlowExtto prepare for future API proposed by JavaFX PR openjdk/jfx#1596by renaming and adding methods in
TextFlowLayoutto match those proposed forLayoutInfo.When the proposed API is integrated and available in JavaFX GA the following steps can be taken:
TextFlowExt.textLayout()method togetLayoutInfo()TextFlowExt.getLayoutInfo()method and reference field.TextFlowLayoutandTextFlowSpan.Special thanks to @andy-goryachev-oracle