Fix add-users script #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Dockerfile to combine some instructions and hopefully reduce number of layers in the image. - Updated add_users script to try and debug why some files permissions are not updating. - Added pubkey authentication to sshd_config for sftp - Updated supervisord conf to have logging for various services.
- Since these files should not be updated through S3 their permissions should always be the same so just create them for each user at startup instead of checking/update constantly through the 'add_users' script.
- Update ownership of .ssh folder and authorized_keys files. They weren't owned correctly so ssh wouldn't be able to read them. Both now owned by the sftp user - Updated supervisor config to allow stderr logging for ssh process
…k on EC2 instance.
- One user was regularly experiencing timeouts when transferring data and was fixed by setting the timeout (manually before) to 15 minutes. This should probably just be set for everyone just so it's consistent and doesn't hurt to have it either.
|
Hey @ndigati, can we merge this PR? This is the perfect use case for my ip camera using a s3 bucket 🙏 |
diogopms
reviewed
Nov 6, 2017
| ./autogen.sh && \ | ||
| ./configure && \ | ||
| make && \ | ||
| sudo make install |
There was a problem hiding this comment.
The sudo it's not required for make install. What do you think?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where sometimes the add-users script would not work because it would error out and exit before
chownorchmodall the files it was supposed to.One case I found for this is when a users home directory had no files the
xargscommand would fail.Changes that happened:
findandxargscommands in add-users scriptxargsto not process empty arguments passed to it (when no files in users home directory)findto only look at files/folders in the users home directory