You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
refactor: improve error bubbling implementation based on PR feedback
- Replace confusing variable names (_err2 -> _err, _ret -> _returnData) in ExecutionEnvironment.sol
- Update test naming convention to follow project standards (test_ErrorHandling_*)
- Replace try-catch pattern with low-level call pattern in tests for cleaner code
- Remove console.log statements from tests
- Add comprehensive test coverage for all error bubbling scenarios:
- PreOps failures
- UserOp delegatecall and regular call failures
- AllocateValue failures
- PreSolver and PostSolver failures
- Security test for malicious solver error spoofing
- Fix test configuration to include proper gas limits for all UserOperations
These changes address all feedback from PR #500 while maintaining the core functionality
of preserving Atlas error selectors with appended DApp error data.
Co-Authored-By: BenSparksCode <noreply@github.com>
0 commit comments