fix: updateAnalytics() takes gasValueUsed arg
#412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenSparksCode
requested review from
0x1NotMe,
jj1980a,
aanand1,
jgcogsystematictrading,
Code0x2,
thogard785 and
Bbasche
and removed request for
0x1NotMe
|
Oof this pushes Atlas over the contract size limit. 77 bytes over. I suspect due to SafeCast. Will make a separate branch to bump OZ version from 4.8 to 5.0, which moves to custom errors. That should free up some space. |
|
Atlas is back under size limit now (#413 lowered sizes a bit), so this is ready for final review. |
0x1NotMe
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We track the ETH value of gas used by solvers for analytics purposes. There was a bug in this tracking code where the value passed into
_updateAnalytics()was already in the form of the ETH cost (i.e.gasUsed * tx.gasprice) but was multiplied bytx.gaspriceagain in the helper. This caused an overflow.Fixes:
* tx.gaspriceoperation.uint64datatype.