Add config for multiple successful solvers #471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvers, added sum of multiple bids, added handling and event emission
Accounting Handling for multiple successful solvers
|
Closing this as its included in the Atlas v1.6 update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new multipleSuccessfulSolvers config will operate in the following way:
Used to define an app specific ordering rule, not a backrun style auction, for an app that multiple solvers can execute successfully in. Specifically this is designed to incorporate ordering rules that are not totally based on Atlas bidAmount, it can operate with Atlas bidAmounts of 0. This module for instance extracts a different app specific bid style from the SolverOp data field https://github.com/FastLane-Labs/atlas-curvance-dapp-control/blob/1fa8c21a945f6ae26f215254a08516dd324586a6/src/CurvancePenaltyDAppControl.sol#L160. Reverts still occur if a standard Atlas bidAmount is not paid. The app side logic handles reverting solvers who do not pay the app-specific bid amount.
Each solver must cover their own gas costs in this config.
allocateValue now proceeds with a summed bidAmount from all solvers.