Consolidate chain-specific deployment parameters #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x1NotMe
force-pushed
the
consolidate-chain-params
branch
from
cd96c07 to
64e6875
Compare
- Add ChainConfig library as single source of truth for chain parameters - Remove hardcoded values from deployment scripts - Support automatic L2 Gas Calculator deployment for OP Stack chains - Add comprehensive documentation for chain configuration system - Redirect Arbitrum deployments to dedicated branches - Rename gas calculator script to reflect OP Stack support Implements #502
0x1NotMe
force-pushed
the
consolidate-chain-params
branch
from
64e6875 to
1dd3668
Compare
BenSparksCode
requested changes
Aug 25, 2025
- Add native support for Arbitrum mainnet (42161) and Sepolia (421614) - Remove references to v1.7-exp branch (not ready for use) - Update deploy-gas-calculator-arbitrum.s.sol to properly deploy ArbitrumGasCalculator - Update deploy-atlas.s.sol to handle both OP Stack and Arbitrum gas calculators - Update requiresL2GasCalculator to include Arbitrum chains - Update documentation to reflect native Arbitrum support Addresses review feedback
0x1NotMe
force-pushed
the
consolidate-chain-params
branch
from
eb37e4c to
1b00ba7
Compare
- Ethereum: Reduced escrow from 768s to 120s (10 blocks × 12s) - Berachain: Updated block time from 5s to 2s (15 blocks × 2s = 30s) - Hyperliquid: Kept at 1s block time (30 blocks × 1s = 30s) - OP Stack (Optimism/Base): Updated to 200ms flashblocks (150 blocks × 200ms = 30s) - Unichain: Kept at 1s block time as confirmed (30 blocks × 1s = 30s) All escrow durations now target ~30 seconds consistently
0x1NotMe
force-pushed
the
consolidate-chain-params
branch
2 times, most recently
from
55a181b to
57a5ce3
Compare
|
Hyperliquid info is still wrong. I'm pretty sure its not 1s blocks |
| } else if (chainId == 999) { | ||
| // Hyperliquid | ||
| return ChainParameters({ | ||
| escrowDuration: 30, // ~1 second * 30 blocks = 30 seconds |
There was a problem hiding this comment.
This needs to be larger. See how fast blocks are added here: https://app.hyperliquid.xyz/explorer definitely not 1s
BenSparksCode
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ChainConfiglibrary to manage chain parameters centrallyChanges
New ChainConfig Library
src/contracts/libraries/ChainConfig.solas the central repository for chain parametersDeployment Script Updates
deploy-atlas.s.solto use ChainConfig and auto-deploy L2 Gas Calculator when neededdeploy-base.s.solto fetch parameters from ChainConfigdeploy-gas-calculator-base.s.soltodeploy-gas-calculator-op-stack.s.solfor broader OP Stack supportdeploy-gas-calculator-arbitrum.s.solto properly deploy ArbitrumGasCalculatordeploy-atlas-hyperliquid.s.sol(unified deployment now handles all chains)L2 Gas Calculator Auto-Deployment
Documentation
docs/CHAIN_CONFIG.mddocumenting the new systemSupported Chains
Testing