JsonSetter.contentNulls ignored for Object[], String[] and Collection<String>
#5202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
commented
Jun 21, 2025
There was a problem hiding this comment.
As confirmed by the following comment, the EnumSetDeserializer has not been modified.
#5165 (comment)
Also, implemented according to the following comment.
#5174 (comment)
1 task
cowtowncoder
reviewed
Jul 9, 2025
src/test/java/com/fasterxml/jackson/databind/deser/jdk/ObjectArrayDeserializer5165Test.java
Show resolved
Hide resolved
cowtowncoder
reviewed
Jul 9, 2025
| } | ||
|
|
||
| @Test | ||
| public void nullsFailTest() { |
There was a problem hiding this comment.
Same as with Object[], no nulls exists in test JSON; test does not trigger handling at all.
cowtowncoder
changed the title
JsonSetter.contentNulls ignored for Object[], String[] and Collection<String>
|
Thanks for the review! |
|
@k163377 Thank you for the PR, as always! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA
This is a continuation of #5191.