Skip to content

Allow passing ParserImpl by a subclass or overwrite the events #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2024
Merged

Allow passing ParserImpl by a subclass or overwrite the events #482

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46aeb00
Allow to replace the ParserImpl by a subclass or overwrite the events
HeikoBoettger Jul 19, 2024
c7ee5ee
Fix compilation issues
cowtowncoder Jul 19, 2024
8562bf4
Add actual overload of `getEvent()` access
cowtowncoder Jul 19, 2024
e1a31dd
...
cowtowncoder Jul 19, 2024
128c1a4
Update release notes
cowtowncoder Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions yaml/src/main/java/com/fasterxml/jackson/dataformat/yaml/YAMLParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,18 +190,22 @@ public YAMLParser(IOContext ctxt, BufferRecycler br,
{
this(ctxt, parserFeatures, formatFeatures, null, codec, reader);
}

public YAMLParser(IOContext ctxt, int parserFeatures, int formatFeatures,
LoaderOptions loaderOptions, ObjectCodec codec, Reader reader)
{
this(ctxt, parserFeatures, formatFeatures, codec,
new ParserImpl(new StreamReader(reader), (loaderOptions == null) ? new LoaderOptions() : loaderOptions))
}

protected YAMLParser(IOContext ctxt, int parserFeatures, int formatFeatures,
ObjectCodec codec, ParserImpl yamlParser)
{
super(ctxt, parserFeatures);
_objectCodec = codec;
_formatFeatures = formatFeatures;
_reader = reader;
if (loaderOptions == null) {
loaderOptions = new LoaderOptions();
}
_yamlParser = new ParserImpl(new StreamReader(reader), loaderOptions);
_yamlParser = yamlParser;
_cfgEmptyStringsToNull = Feature.EMPTY_STRING_AS_NULL.enabledIn(formatFeatures);
}

Expand Down Expand Up @@ -415,12 +419,22 @@ protected JsonLocation _locationFor(Mark m)

// Note: SHOULD override 'getTokenLineNr', 'getTokenColumnNr', but those are final in 2.0

/**
* Since the parserImpl cannot be replaced allow subclasses to at least be able to
* influence the events being consumed.
*
* A particular use case is working around the lack of anchor and alias support to
* emit additional events.
*/
protected Event getEvent() {
return _yamlParser.getEvent();
}

/*
/**********************************************************
/* Parsing
/**********************************************************
*/

@SuppressWarnings("deprecation")
@Override
public JsonToken nextToken() throws IOException
Expand Down
Loading