Skip to content
This repository was archived by the owner on Nov 7, 2019. It is now read-only.

Commit c514bcf

Browse files
committed
Merge pull request #68 from Arzie/master
Handle JSON serialized Dates from JavaScript in LocalDateTimeDeserializer
2 parents 520a8f4 + 6a98cf9 commit c514bcf

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

src/main/java/com/fasterxml/jackson/datatype/jsr310/deser/LocalDateTimeDeserializer.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
import java.io.IOException;
2020
import java.time.DateTimeException;
21+
import java.time.Instant;
2122
import java.time.LocalDateTime;
23+
import java.time.ZoneOffset;
2224
import java.time.format.DateTimeFormatter;
2325

2426
import com.fasterxml.jackson.core.JsonParser;
@@ -40,10 +42,12 @@ public class LocalDateTimeDeserializer
4042
{
4143
private static final long serialVersionUID = 1L;
4244

45+
private static final DateTimeFormatter DEFAULT_FORMATTER = DateTimeFormatter.ISO_LOCAL_DATE_TIME;
46+
4347
public static final LocalDateTimeDeserializer INSTANCE = new LocalDateTimeDeserializer();
4448

4549
private LocalDateTimeDeserializer() {
46-
this(DateTimeFormatter.ISO_LOCAL_DATE_TIME);
50+
this(DEFAULT_FORMATTER);
4751
}
4852

4953
public LocalDateTimeDeserializer(DateTimeFormatter formatter) {
@@ -63,7 +67,19 @@ public LocalDateTime deserialize(JsonParser parser, DeserializationContext conte
6367
if (string.length() == 0) {
6468
return null;
6569
}
70+
6671
try {
72+
if (_formatter == DEFAULT_FORMATTER) {
73+
// JavaScript by default includes time and zone in JSON serialized Dates (UTC/ISO instant format).
74+
if (string.length() > 10 && string.charAt(10) == 'T') {
75+
if (string.endsWith("Z")) {
76+
return LocalDateTime.ofInstant(Instant.parse(string), ZoneOffset.UTC);
77+
} else {
78+
return LocalDateTime.parse(string, DEFAULT_FORMATTER);
79+
}
80+
}
81+
}
82+
6783
return LocalDateTime.parse(string, _formatter);
6884
} catch (DateTimeException e) {
6985
_rethrowDateTimeException(parser, e);

src/test/java/com/fasterxml/jackson/datatype/jsr310/TestLocalDateTimeSerialization.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,10 @@
2424
import org.junit.Before;
2525
import org.junit.Test;
2626

27+
import java.time.Instant;
2728
import java.time.LocalDateTime;
2829
import java.time.Month;
30+
import java.time.ZoneOffset;
2931
import java.time.temporal.Temporal;
3032
import java.util.Calendar;
3133
import java.util.Date;
@@ -314,13 +316,23 @@ public void testDeserializationAsString03() throws Exception
314316
assertEquals("The value is not correct.", time, value);
315317
}
316318

319+
@Test
320+
public void testDeserializationAsString04() throws Exception
321+
{
322+
Instant instant = Instant.now();
323+
LocalDateTime value = mapper.readValue('"' + instant.toString() + '"', LocalDateTime.class);
324+
325+
assertNotNull("The value should not be null.", value);
326+
assertEquals("The value is not correct.", LocalDateTime.ofInstant(instant, ZoneOffset.UTC), value);
327+
}
328+
317329
@Test
318330
public void testDeserializationWithTypeInfo01() throws Exception
319331
{
320332
LocalDateTime time = LocalDateTime.of(2005, Month.NOVEMBER, 5, 22, 31, 5, 829837);
321333

322334
final ObjectMapper m = newMapper().addMixIn(Temporal.class, MockObjectConfiguration.class);
323-
335+
324336
m.configure(DeserializationFeature.READ_DATE_TIMESTAMPS_AS_NANOSECONDS, true);
325337
Temporal value = m.readValue(
326338
"[\"" + LocalDateTime.class.getName() + "\",[2005,11,5,22,31,5,829837]]", Temporal.class

0 commit comments

Comments
 (0)