IllegalAccessException on final field

[smeder]

I'm getting the following exception:

WARN [2014-08-18 13:57:17,088] com.kosei.dropwizard.advertiser.api.JsonOrganization$Access4JacksonDeserializer: Disabling Afterburner deserialization for type class com.kosei.dropwizard.advertiser.api.JsonOrganization, field #0, due to access error (type java.lang.IllegalAccessError, message=null)

! java.lang.IllegalAccessError: null
! at com.kosei.dropwizard.advertiser.api.JsonOrganization$Access4JacksonDeserializer.objectField(com.kosei.dropwizard.advertiser.api.JsonOrganization$Access4JacksonDeserializer.java) ~[na:0.16]
! at com.fasterxml.jackson.module.afterburner.deser.BeanPropertyMutator.objectField(BeanPropertyMutator.java:142) ~[jackson-module-afterburner-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.module.afterburner.deser.SettableObjectFieldProperty.set(SettableObjectFieldProperty.java:58) [jackson-module-afterburner-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.databind.deser.impl.PropertyValue$Regular.assign(PropertyValue.java:62) [jackson-databind-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.databind.deser.impl.PropertyBasedCreator.build(PropertyBasedCreator.java:173) [jackson-databind-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.databind.deser.BeanDeserializer._deserializeUsingPropertyBased(BeanDeserializer.java:398) [jackson-databind-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.deserializeFromObjectUsingNonDefault(BeanDeserializerBase.java:1056) [jackson-databind-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.module.afterburner.deser.SuperSonicBeanDeserializer.deserializeFromObject(SuperSonicBeanDeserializer.java:190) [jackson-module-afterburner-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:124) [jackson-databind-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.module.afterburner.deser.SuperSonicBeanDeserializer.deserialize(SuperSonicBeanDeserializer.java:109) [jackson-module-afterburner-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.databind.ObjectReader._bind(ObjectReader.java:1232) [jackson-databind-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.databind.ObjectReader.readValue(ObjectReader.java:676) [jackson-databind-2.4.2.jar:2.4.2]
! at com.fasterxml.jackson.jaxrs.base.ProviderBase.readFrom(ProviderBase.java:808) [jackson-jaxrs-base-2.4.2.jar:2.4.2]

when deserializing to

@JsonInclude(JsonInclude.Include.NON_NULL)
public class JsonOrganization extends Resource<JsonOrganization> {
    public static final String ORGANIZATION_LINK_NAME = "organization";
    public final long id;
    public final String name;
    public final JsonAddress address;

    @JsonCreator
    public JsonOrganization(@JsonProperty("id") long id,
                            @JsonProperty("name") String name,
                            @JsonProperty("address") JsonAddress address)
    {
        this.id = id;
        this.name = name;
        this.address = address;
    }
}

I am assuming that is not expected? Plain Jackson deserializes it without problems.

[cowtowncoder]

Interesting. Thank you for providing the test case, and yes, things should work functionally the same way with or without Afterburner, so this is a bug.

[cowtowncoder]

Unfortunately I am not able to reproduce your problem just by using included types, simple test instance.

[smeder]

Hmm, ok. Going to dig in a bit more. This is happening for REST calls in Dropwizard (0.7.1), so I'm not setting up the mapper myself. I'll let you know what I find (might be a few days)

[cowtowncoder]

@smeder Ok thanks. I just mentioned oddities I observed wrt final members, since it sounds like this problem might be quite context-sensitive. For example, only occurring for child objects, or for parents, or something with both parent and children.

[smeder]

Finally got around to looking into this again. I put together a very simple test case that triggers it every time for me: https://gist.github.com/smeder/485f31cdd339691ca355

In case it matters, I am running on Java 8:

java version "1.8.0_05"
Java(TM) SE Runtime Environment (build 1.8.0_05-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.5-b02, mixed mode)

[cowtowncoder]

Hmmh. And it passes on my local 1.7 build...

[cowtowncoder]

Also passes with 1.8 locally. I run on MacOS, for what that is worth.

[smeder]

Hmm, ok. I'll have to play around a bit more with my environment to see if I can isolate what is causing the different behavior.

[bimargulies]

I've hit this. Let me see if I can abstract to a test case.

[cowtowncoder]

Ok. In general, I think I'd suggest NOT trying to inject final fields for anything but "leaf" types (ones that do not refer to structured types). It appears there is some magical limit on how long final fields are actually mutable (to allow JDK serialization, as far as I know); and looks like that limit may be triggered quite easily.

Perhaps there is a way around this, but just something to keep in mind when working around issues.

[bimargulies]

@cowtowncoder

https://github.com/bimargulies/afterburner-tc is a test case for you. There's a standard reflection trick to disable final protection on non-static fields, is there not? In my test case, there's a registered constructor creator, so the problem of final should not be a problem. In short, my test case may give you two problems: 1: afterburner ignoring a mixin with a JsonCreator, and 2: the final problem.

[smeder]

From the discussion I guess I don't really understand how this is supposed to work. Why do you need to mutate final fields when there is a JsonCreator annotated constructor?

[smeder]

Ok, updated my test code (https://gist.github.com/smeder/485f31cdd339691ca355) and realized that it was triggering because the Resource super class has a property that is not being included in the constructor. I'm guessing that this triggers a fallback mechanism that tries to mutate the final fields? Is there any way to mark a field as read only?