Skip to content

feat: support strapi v5 #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Feb 2, 2025
Merged

feat: support strapi v5 #411

merged 55 commits into from
Feb 2, 2025

Conversation

sargreal
Copy link
Member

@sargreal sargreal commented Aug 22, 2024 •
edited
Loading

BREAKING CHANGE: This will make the plugin incompatible with Strapi v4

fixes #404

Changes and Todos:

@sargreal sargreal self-assigned this Aug 23, 2024
@sargreal sargreal added the enhancement New feature or request label Aug 23, 2024
@sargreal sargreal added this to the v2.0 milestone Aug 23, 2024
@sargreal sargreal linked an issue Nov 19, 2024 that may be closed by this pull request
[UPGRADE]: Strapi v5 #404
Open
@sargreal sargreal force-pushed the strapi-v5 branch 2 times, most recently from c3f5b23 to c6569bb Compare November 20, 2024 09:28
@sargreal sargreal mentioned this pull request Dec 16, 2024
Closed
@Boegie19
Copy link

Boegie19 commented Dec 16, 2024 •
edited
Loading

@sargreal Mind trying someting for me replace @strapi/content-manager/strapi-admin with @strapi/strapi/admin

My guess is that all strapi-admin exports are broken

@sargreal
Copy link
Member Author

@sargreal Mind trying someting for me replace @strapi/content-manager/strapi-admin with @strapi/strapi/admin

My guess is that all strapi-admin exports are broken

Thanks for your comment @Boegie19. However all of the imports that are from some strapi-admin are only type imports.

I have just confirmed that they are not causing the issue by removing those imports locally.

@sargreal sargreal force-pushed the strapi-v5 branch 2 times, most recently from 8876a1d to b3b4d1c Compare January 28, 2025 07:19
@sargreal sargreal marked this pull request as ready for review February 2, 2025 13:27
@sargreal sargreal requested a review from layaxx February 2, 2025 13:27
@sargreal
Copy link
Member Author

sargreal commented Feb 2, 2025 •
edited
Loading

@layaxx Sorry for this huge PR.. I believe most of this should be fine for a pre-release.

e2e tests are failing currently for some unknown reason. In some cases the strapi app fails to load, which results in the "nav not found" errors. Locally it works most of the time

sargreal added 14 commits February 2, 2025 17:15
@sargreal
feat(plugin): migrate plugin to strapi v5
76f3455 
migrate plugin to typescript
migrate plugin tests to typescript
migrate design-system changes
reimplement untranslated service
update plugin routes

BREAKING CHANGE: drops support for strapi v4
BREAKING CHANGE: plugin is now typescript
BREAKING CHANGE: plugin routes have been changed
fixes #404
fixes #412
@sargreal
fix(admin): migrate direct translation to a header action
dfc0723
@sargreal
feat: create translateEntity service
c8df746
@sargreal
test(plugin): update tests for typescript and strapi v5
ea9ebab
@sargreal
chore: fix package.json scripts
e08e296
@sargreal
fix(admin): select default locale by default in translation
1200472
@sargreal
refactor: remove console logs
ad7d253
@sargreal
fix: update config.get usage
f1f9c18 
replace plugin.translate with plugin::translate
the single dot notation is deprecated
@sargreal
fix: populate rule
3b8e1e8
@sargreal
chore(playground): fix reset script
0dc7771
@sargreal
test: first changes to e2e tests
6708c72 
test(e2e): finish updating tests
@sargreal
fix: updated entry subscription
86215b3
@sargreal
fix(batch-update): tables and hooks
25e1754
@sargreal
fix: route for deleting updated entries
31789d5
sargreal added 21 commits February 2, 2025 17:25
@sargreal
feat(provider): migrate providers to typescript
a921e19
@sargreal
ci(lint): verify providers as well
ea2c36b
@sargreal
build(plugin): fix export targets
0a0b392
@sargreal
ci(unittest): build plugin before tests
e0547d2
@sargreal
ci(release): build plugin and providers
c111aa1
@sargreal
chore: remove unused imports
11b7558
@sargreal
fix(admin): cannot use useStrapi outside of StrapiApp
498f14a 
Use npm instead of yarn, which seems to solve this issue.
See strapi/strapi#22162
@sargreal
test(batch-translate): migrate tests to typescript
9ad25cb
@sargreal
test(untranslated-service): migrate tests to typescript
1ab9d1d
@sargreal
test(dummy-provider): migrate tests to typescript
3065842
@sargreal
fix(populate-all): break early if attributeSchema is empty
5303220
@sargreal
test(mock): throw error if content type does not exist
d2ed1e7
@sargreal
fix(utils): incorrect populate-all rule for dynamiczone and components
519370d
@sargreal
chore: remove duplicated code for entity translation
1d4522d
@sargreal
fix(admin): show alert on translation error again
d295583
@sargreal
fix: batch translation stopping directly after setup
ee34052
@sargreal
test(e2e): update tests to be more stable
d369425
@sargreal
test(plugin): update populate and controller tests
575a8bf
@sargreal
test(e2e): increase default timeout
693f9ff 
sometimes strapi takes some time to load
@sargreal
chore(deps): cleanup dependencies
1ee7b70
@sargreal
chore(prettier): format all files
5ac5895
@sargreal sargreal merged commit 2a561f2 into next Feb 2, 2025
9 of 14 checks passed
@fekide-bot
Copy link

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.3.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.2.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.3.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.2.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layaxx layaxx Awaiting requested review from layaxx

Assignees

@sargreal sargreal

Labels

enhancement New feature or request released on @next

Projects

Translate Strapi Plugin
Status: Done

Milestone

v2.0

Development

Successfully merging this pull request may close these issues.

[UPGRADE]: Strapi v5

3 participants

@sargreal @Boegie19 @fekide-bot