fix(provider-deepl): glossary handling #501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #500 Add support for multiple glossaries in the deepl provider. - Update `providers/deepl/lib/index.js` to handle multiple glossaries from `providerOptions` and select the appropriate glossary based on the source and target locale. - Add logic to convert source and target language using `parseLocale` function. - Add a warning log if a glossary is provided in `apiOptions` and overwrite it with the actual glossary to be used for the translation. - Write tests in `providers/deepl/lib/__tests__/deepl.test.js` to verify that glossaries are handled correctly and that a warning is logged when a glossary is provided in `apiOptions`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Fekide/strapi-plugin-translate/issues/500?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500
Add support for multiple glossaries in the deepl provider.
providers/deepl/lib/index.jsto handle multiple glossaries fromproviderOptionsand select the appropriate glossary based on the source and target locale.parseLocalefunction.apiOptionsand overwrite it with the actual glossary to be used for the translation.providers/deepl/lib/__tests__/deepl.test.jsto verify that glossaries are handled correctly and that a warning is logged when a glossary is provided inapiOptions.For more details, open the Copilot Workspace session.