feat(telemetry): honor DO_NOT_TRACK + print first-run notice (#166 step 5)#409
Merged
Merged
Conversation
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 4863998 | Previous: 0b5fe57 | Ratio |
|---|---|---|---|
git_changed_since_tag/100_commits_50_since |
2830392 ns/iter (± 9880) |
||
git_changed_since_tag/1000_commits_500_since |
28580851 ns/iter (± 877383) |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5 of FerrLabs-Cloud#166 — adoption of the cross-tool DO_NOT_TRACK standard and a first-run notice.
Telemetry changes
DO_NOT_TRACK=1now disables anonymous telemetry, alongsideFERRFLOW_TELEMETRY=0/FERRFLOW_ANONYMOUS_TELEMETRY=0.DO_NOT_TRACKwins if set to1/true/yes/on.First invocation prints one line to stderr:
A marker file at
$XDG_STATE_HOME/ferrflow/.telemetry-notice-shown(with platform fallbacks for macOS / Windows, override viaFERRFLOW_STATE_DIR) suppresses subsequent runs. We never silently re-enable telemetry.3 new unit tests cover
DO_NOT_TRACKparsing + the marker path resolver.Drive-by clippy cleanup
The
.githooks/pre-commithook (cargo clippy --workspace --all-targets -- -D warnings) was failing on pre-existing issues that prevented any commit:benches/ferrflow_benchmarks.rs—criterion::black_boxdeprecated, switched tostd::hint::black_boxand reshaped 2 call sites that violatedunit_arg.src/formats/{csproj,gradle,json,toml_format,txt}.rs— these put#[cfg(test)] mod testsbefore theimpl VersionFileblock (test-first reading order). Theitems_after_test_modulelint is now allowed at the workspace level rather than reorganising 5 files.Refs Changelog#5 entry.