chore(hooks): mirror CI checks in pre-push hook#425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the test-only pre-push with the fmt+clippy pair that gates the CI 'Test' job and currently slip through to GitHub Actions every push. The full test suite (cargo nextest) is intentionally left out of pre-push — the cargo crate is heavy enough that running tests on every push would push the hook well past the 3-minute developer-budget.
.githooks/pre-pushruns:cargo fmt --all -- --check(mirrorstest.Format check)cargo clippy --all-targets -- -D warnings(mirrorstest.Clippy)Skips:
cargo nextest run --no-fail-fast— too slow for a pre-push budget; CI keeps running it.cargo audit/cargo deny/cargo machete—securityjob covers these in CI.To activate: run
bash .githooks/install.shonce (setscore.hooksPath=.githooks).Test plan
cargo fmt --checkandcargo clippy --all-targets -- -D warningspass on a clean checkoutbash .githooks/install.shthengit push --dry-rundoes not crash