Skip to content

QoL magic shop menu update #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

1nf3rna
Copy link

@1nf3rna 1nf3rna commented May 16, 2025

added a QoL flag to change the magic shops to function like the weapon and armor shops.
Select Spell > Pay > Select Character

@FranklinFFR
Copy link

Cool Idea! I think I would like using this flag

1nf3rna and others added 23 commits May 23, 2025 01:36
* New Alt Fiend Art

* New Friends Added

* Update ImageSharp
* Adding Alt Fiends and testing code to for Alt fiends selection (currently broken)

* Finished adding fiends

* Alt Fiend Code Re-done, working

* Alt Fiends work

* Fiends added, tool tips updated

* Added final FF4 fiends

* Alt Fiend code finished

* Fixed Bad Fiends

* Fixed Fiend errors

* Fixed missing value on fiend

* Subshell for FF5 fiends created

* Gave Bubbles back Fade

* Hurray Added
Start of FF5

* 2 more fiends added

* More Fiends added

* All 'C' fiend finished

* Finished D and E, moved Gilly back home to FFV

* Fiends to 'O' completed

* All FFV fiends Finished

* Added Missing Tool Tip

* FF6 Fiends entered, first 4

* Missing Flagset

* More Fiend work

* Missing code re-added

* Troubleshooting hanging fiends

* Confirmed Alt Fiends working

* D's and E's finished

* 'F' Fiends finished and tested

* Finished G and H Fiends

* "I" Fiends completed

* "K" Fiends finished

* "N" Fiends Done

* "P" Fiends added and Tested

* Missing M Master and R fiends done

* "S" Fiends Done

* Started on "T" Fiends

* "T" Fiends completed

* FF6 fiends completed

* Tooltip added for FF6 Fiends

* Testing

* Update to fiend skills

* Fixed error

* Removed Ruse from Alt Fiend Scripts

* Fiend Code Clean Up

* New Fiends added

* FF2 to FF4 Fiend Patch applied

* FF5 Fiends Patched

* FF6 Fiend Patch applied

* FF1Bonus Fiend patch applied

* New Alt Fiends added to pool

* Tooltips Updates

* Code Clean Up

* Updated Alt Fiend Images

* More Fiend Updates

* New Alt Fiend Art

* New Friends Added

* New Alt Fiend added
* Adding Alt Fiends and testing code to for Alt fiends selection (currently broken)

* Finished adding fiends

* Alt Fiend Code Re-done, working

* Alt Fiends work

* Fiends added, tool tips updated

* Added final FF4 fiends

* Alt Fiend code finished

* Fixed Bad Fiends

* Fixed Fiend errors

* Fixed missing value on fiend

* Subshell for FF5 fiends created

* Gave Bubbles back Fade

* Hurray Added
Start of FF5

* 2 more fiends added

* More Fiends added

* All 'C' fiend finished

* Finished D and E, moved Gilly back home to FFV

* Fiends to 'O' completed

* All FFV fiends Finished

* Added Missing Tool Tip

* FF6 Fiends entered, first 4

* Missing Flagset

* More Fiend work

* Missing code re-added

* Troubleshooting hanging fiends

* Confirmed Alt Fiends working

* D's and E's finished

* 'F' Fiends finished and tested

* Finished G and H Fiends

* "I" Fiends completed

* "K" Fiends finished

* "N" Fiends Done

* "P" Fiends added and Tested

* Missing M Master and R fiends done

* "S" Fiends Done

* Started on "T" Fiends

* "T" Fiends completed

* FF6 fiends completed

* Tooltip added for FF6 Fiends

* Testing

* Update to fiend skills

* Fixed error

* Removed Ruse from Alt Fiend Scripts

* Fiend Code Clean Up

* New Fiends added

* FF2 to FF4 Fiend Patch applied

* FF5 Fiends Patched

* FF6 Fiend Patch applied

* FF1Bonus Fiend patch applied

* New Alt Fiends added to pool

* Tooltips Updates

* Code Clean Up

* Updated Alt Fiend Images

* More Fiend Updates

* New Alt Fiend Art

* New Friends Added

* New Alt Fiend added

* Fixed error
* Adding Alt Fiends and testing code to for Alt fiends selection (currently broken)

* Finished adding fiends

* Alt Fiend Code Re-done, working

* Alt Fiends work

* Fiends added, tool tips updated

* Added final FF4 fiends

* Alt Fiend code finished

* Fixed Bad Fiends

* Fixed Fiend errors

* Fixed missing value on fiend

* Subshell for FF5 fiends created

* Gave Bubbles back Fade

* Hurray Added
Start of FF5

* 2 more fiends added

* More Fiends added

* All 'C' fiend finished

* Finished D and E, moved Gilly back home to FFV

* Fiends to 'O' completed

* All FFV fiends Finished

* Added Missing Tool Tip

* FF6 Fiends entered, first 4

* Missing Flagset

* More Fiend work

* Missing code re-added

* Troubleshooting hanging fiends

* Confirmed Alt Fiends working

* D's and E's finished

* 'F' Fiends finished and tested

* Finished G and H Fiends

* "I" Fiends completed

* "K" Fiends finished

* "N" Fiends Done

* "P" Fiends added and Tested

* Missing M Master and R fiends done

* "S" Fiends Done

* Started on "T" Fiends

* "T" Fiends completed

* FF6 fiends completed

* Tooltip added for FF6 Fiends

* Testing

* Update to fiend skills

* Fixed error

* Removed Ruse from Alt Fiend Scripts

* Fiend Code Clean Up

* New Fiends added

* FF2 to FF4 Fiend Patch applied

* FF5 Fiends Patched

* FF6 Fiend Patch applied

* FF1Bonus Fiend patch applied

* New Alt Fiends added to pool

* Tooltips Updates

* Code Clean Up

* Updated Alt Fiend Images

* More Fiend Updates

* New Alt Fiend Art

* New Friends Added

* New Alt Fiend added

* Fixed error

* Fixed Issue With Fiend Code
…d Hex Blob here. Currently can't include 'Who will learn message' due to not enough ROM memory available (exceeds by 5 bytes).
@1nf3rna 1nf3rna force-pushed the QoS_Magic_Shop_Menu_Update branch from 5e9773f to b95e7d7 Compare May 23, 2025 05:38
@1nf3rna
Copy link
Author

1nf3rna commented May 23, 2025

removed the tristate flag stuff, since that's a different pull request

@1nf3rna 1nf3rna marked this pull request as draft May 23, 2025 05:56
@1nf3rna 1nf3rna marked this pull request as ready for review May 24, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants