-
Notifications
You must be signed in to change notification settings - Fork 49
QoL magic shop menu update #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1nf3rna
wants to merge
24
commits into
FiendsOfTheElements:dev
Choose a base branch
from
1nf3rna:QoS_Magic_Shop_Menu_Update
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
QoL magic shop menu update #1124
1nf3rna
wants to merge
24
commits into
FiendsOfTheElements:dev
from
1nf3rna:QoS_Magic_Shop_Menu_Update
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cool Idea! I think I would like using this flag |
* New Alt Fiend Art * New Friends Added * Update ImageSharp
* Adding Alt Fiends and testing code to for Alt fiends selection (currently broken) * Finished adding fiends * Alt Fiend Code Re-done, working * Alt Fiends work * Fiends added, tool tips updated * Added final FF4 fiends * Alt Fiend code finished * Fixed Bad Fiends * Fixed Fiend errors * Fixed missing value on fiend * Subshell for FF5 fiends created * Gave Bubbles back Fade * Hurray Added Start of FF5 * 2 more fiends added * More Fiends added * All 'C' fiend finished * Finished D and E, moved Gilly back home to FFV * Fiends to 'O' completed * All FFV fiends Finished * Added Missing Tool Tip * FF6 Fiends entered, first 4 * Missing Flagset * More Fiend work * Missing code re-added * Troubleshooting hanging fiends * Confirmed Alt Fiends working * D's and E's finished * 'F' Fiends finished and tested * Finished G and H Fiends * "I" Fiends completed * "K" Fiends finished * "N" Fiends Done * "P" Fiends added and Tested * Missing M Master and R fiends done * "S" Fiends Done * Started on "T" Fiends * "T" Fiends completed * FF6 fiends completed * Tooltip added for FF6 Fiends * Testing * Update to fiend skills * Fixed error * Removed Ruse from Alt Fiend Scripts * Fiend Code Clean Up * New Fiends added * FF2 to FF4 Fiend Patch applied * FF5 Fiends Patched * FF6 Fiend Patch applied * FF1Bonus Fiend patch applied * New Alt Fiends added to pool * Tooltips Updates * Code Clean Up * Updated Alt Fiend Images * More Fiend Updates * New Alt Fiend Art * New Friends Added * New Alt Fiend added
* Adding Alt Fiends and testing code to for Alt fiends selection (currently broken) * Finished adding fiends * Alt Fiend Code Re-done, working * Alt Fiends work * Fiends added, tool tips updated * Added final FF4 fiends * Alt Fiend code finished * Fixed Bad Fiends * Fixed Fiend errors * Fixed missing value on fiend * Subshell for FF5 fiends created * Gave Bubbles back Fade * Hurray Added Start of FF5 * 2 more fiends added * More Fiends added * All 'C' fiend finished * Finished D and E, moved Gilly back home to FFV * Fiends to 'O' completed * All FFV fiends Finished * Added Missing Tool Tip * FF6 Fiends entered, first 4 * Missing Flagset * More Fiend work * Missing code re-added * Troubleshooting hanging fiends * Confirmed Alt Fiends working * D's and E's finished * 'F' Fiends finished and tested * Finished G and H Fiends * "I" Fiends completed * "K" Fiends finished * "N" Fiends Done * "P" Fiends added and Tested * Missing M Master and R fiends done * "S" Fiends Done * Started on "T" Fiends * "T" Fiends completed * FF6 fiends completed * Tooltip added for FF6 Fiends * Testing * Update to fiend skills * Fixed error * Removed Ruse from Alt Fiend Scripts * Fiend Code Clean Up * New Fiends added * FF2 to FF4 Fiend Patch applied * FF5 Fiends Patched * FF6 Fiend Patch applied * FF1Bonus Fiend patch applied * New Alt Fiends added to pool * Tooltips Updates * Code Clean Up * Updated Alt Fiend Images * More Fiend Updates * New Alt Fiend Art * New Friends Added * New Alt Fiend added * Fixed error
* Adding Alt Fiends and testing code to for Alt fiends selection (currently broken) * Finished adding fiends * Alt Fiend Code Re-done, working * Alt Fiends work * Fiends added, tool tips updated * Added final FF4 fiends * Alt Fiend code finished * Fixed Bad Fiends * Fixed Fiend errors * Fixed missing value on fiend * Subshell for FF5 fiends created * Gave Bubbles back Fade * Hurray Added Start of FF5 * 2 more fiends added * More Fiends added * All 'C' fiend finished * Finished D and E, moved Gilly back home to FFV * Fiends to 'O' completed * All FFV fiends Finished * Added Missing Tool Tip * FF6 Fiends entered, first 4 * Missing Flagset * More Fiend work * Missing code re-added * Troubleshooting hanging fiends * Confirmed Alt Fiends working * D's and E's finished * 'F' Fiends finished and tested * Finished G and H Fiends * "I" Fiends completed * "K" Fiends finished * "N" Fiends Done * "P" Fiends added and Tested * Missing M Master and R fiends done * "S" Fiends Done * Started on "T" Fiends * "T" Fiends completed * FF6 fiends completed * Tooltip added for FF6 Fiends * Testing * Update to fiend skills * Fixed error * Removed Ruse from Alt Fiend Scripts * Fiend Code Clean Up * New Fiends added * FF2 to FF4 Fiend Patch applied * FF5 Fiends Patched * FF6 Fiend Patch applied * FF1Bonus Fiend patch applied * New Alt Fiends added to pool * Tooltips Updates * Code Clean Up * Updated Alt Fiend Images * More Fiend Updates * New Alt Fiend Art * New Friends Added * New Alt Fiend added * Fixed error * Fixed Issue With Fiend Code
…d Hex Blob here. Currently can't include 'Who will learn message' due to not enough ROM memory available (exceeds by 5 bytes).
5e9773f
to
b95e7d7
Compare
removed the tristate flag stuff, since that's a different pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a QoL flag to change the magic shops to function like the weapon and armor shops.
Select Spell > Pay > Select Character