Achieve Over 20% Speedup with PyTorch SDPA #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attention computation is the most time-consuming part during inference. The attention implementation in this project is
which can be accelerated with Pytorch's SDPA.
PyTorch's SDPA achieves significant performance acceleration when no mask is passed, as it can fully leverage flash_attn for acceleration (this library currently does not support attention computations with masks. see Dao-AILab/flash-attention#352)
When
batch_size=1, there is no padding, the attention mask can be removed, thereby allowing PyTorch's SDPA to fully accelerate.Based on my testing, this change brings an average performance improvement of over 20%.