Skip to content

Commit 36759a9

Browse files
authored
Fix github unit test checks (#148)
* break test * Report exit code * fix test * fix tests * fix tests
1 parent dda1de7 commit 36759a9

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

packages/@apphosting/adapter-angular/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,17 @@
4646
"zod": "^3.22.4"
4747
},
4848
"peerDependencies": {
49-
"@angular-devkit/architect": "~0.1700.0",
50-
"@angular-devkit/core": "~17.0.0"
49+
"@angular-devkit/architect": "~0.1702.0",
50+
"@angular-devkit/core": "~17.2.0"
5151
},
5252
"peerDependenciesMeta": {
5353
"@angular-devkit/architect": { "optional": true },
5454
"@angular-devkit/core": { "optional": true }
5555
},
5656
"devDependencies": {
57-
"@angular-devkit/architect": "~0.1700.0",
58-
"@angular-devkit/core": "~17.0.0",
59-
"@angular/core": "~17.0.0",
57+
"@angular-devkit/architect": "~0.1702.0",
58+
"@angular-devkit/core": "~17.2.0",
59+
"@angular/core": "~17.2.0",
6060
"@types/fs-extra": "*",
6161
"@types/mocha": "*",
6262
"@types/tmp": "*",

packages/@apphosting/adapter-angular/src/bin/build.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ staticAssets:
5656
outputBaseDirectory: resolve(".apphosting", "dist"),
5757
outputDirectory: resolve("", ".apphosting"),
5858
serverFilePath: resolve(".apphosting", "server", "server.mjs"),
59+
needsServerGenerated: false,
5960
};
6061
const outputPaths = {
6162
root: new URL("file:///test"),

packages/@apphosting/adapter-angular/src/bin/create.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { spawn } from "child_process";
33

44
import { isMain } from "../utils.js";
55

6-
export const ANGULAR_CLI_VERSION = "~17.0.0";
6+
export const ANGULAR_CLI_VERSION = "~17.2.0";
77

88
const main = isMain(import.meta);
99

scripts/test.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,9 @@
22
const { spawn } = require("child_process");
33
const { lernaScopeArgs } = require("./github.js");
44

5-
spawn("lerna", ["run", "test", "--verbose", "--no-bail", ...lernaScopeArgs], { stdio: "inherit" });
5+
const testProcess = spawn("lerna", ["run", "test", "--verbose", "--no-bail", ...lernaScopeArgs], {
6+
stdio: "inherit",
7+
});
8+
testProcess.on("close", (code) => {
9+
process.exit(code);
10+
});

0 commit comments

Comments
 (0)