fix: sveltekit server endpoint buffer response #159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3tasploit
force-pushed
the
fix-sveltekit
branch
from
ce7914b to
97bfe4f
Compare
|
@m3tasploit LGTM. Q, does the text content-type repsonse work ok if you always respond with a buffer? Best to avoid conditionals when possible |
|
Oh, sorry i forgot that case, I'll try different content types and update code if necessary |
I've added check for commonly used text content-types. I'm not sure if this is the correct way to go. |
|
Hey @m3tasploit, thanks for creating this PR. I did a few tests and found that if we always respond with a buffer it also works, therefore avoiding conditionals. Implemented in #205. |
|
Merged in #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for corrupt images when responding with image/jpeg or any binary data from sveltekit Api endpoint