-
Notifications
You must be signed in to change notification settings - Fork 125
feat: Angular boilerplate #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
</article> | ||
</section> | ||
|
||
<section class="links-container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhuleatt @jamesdaniels please let me know what links should be displayed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW the links were removed in the Next.js boilerplate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove the links, but keep the CSS please so we can easily add them back in later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once links are removed (#174 (comment)).
Seems like CI is failing, is that an easy fix?
Could you add a brief description of what this is for? |
@Yuangwang just added a short description to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments, but otherwise LGTM once the comments are addressed and CI is fixed
@@ -0,0 +1,22 @@ | |||
<h1 class="large-heading">Hello, My App</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed to something else?
I think the nextjs template calls this page "Next.js on Firebase App Hosting" so maybe "Angular on Firebase App Hosting" works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
It was implemented based on designs.
I'm more than happy to introduce some content changes, but I just wanted to be sure that all of us are on the same page.
CC: @jhuleatt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to mirror the Next.js h1
<h1 className="heading">Next.js on Firebase App Hosting</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied proposal in recent commit.
@@ -0,0 +1,3 @@ | |||
<h1 class="heading">Sample title for SSG</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should probably be renamed, maybe just SSG is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the Next.js one to just SSG
so I think this one can follow
<h1 className="heading">SSG</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied proposal in recent commit.
updated this PR to get the package lock fix from #173 |
Hi @Yuangwang, The build step is failing on CI, locally it works fine. The following error occurs:
It looks like it's unrelated to changes in this PR. |
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
PR includes a basic Angular Hello World boilerplate for Firebase App Hosting.
It shows basic features like: