Skip to content

feat: Angular boilerplate #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2024
Merged

feat: Angular boilerplate #174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e04354f
feat: Angular boilerplate
9kubczas4 May 3, 2024
132d7ca
feat: remove links container
9kubczas4 May 6, 2024
03582d4
Merge branch 'main' into pawelkubiak_angular-boilerplate
leoortizz May 6, 2024
2601683
feat: revert removing styles for links
9kubczas4 May 6, 2024
23b0a73
feat: update titles
9kubczas4 May 6, 2024
477befc
Update starters/angular/basic/README.md
9kubczas4 May 6, 2024
a2e00db
Update starters/angular/basic/server.ts
9kubczas4 May 6, 2024
06798aa
Merge branch 'main' into pawelkubiak_angular-boilerplate
Yuangwang May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions starters/angular/basic/src/app/pages/home/home.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<h1 class="large-heading">Hello, My App</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to something else?

I think the nextjs template calls this page "Next.js on Firebase App Hosting" so maybe "Angular on Firebase App Hosting" works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

It was implemented based on designs.
I'm more than happy to introduce some content changes, but I just wanted to be sure that all of us are on the same page.

CC: @jhuleatt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to mirror the Next.js h1

firebase-framework-tools/starters/nextjs/basic/src/app/page.tsx

Line 6 in e821aff

<h1 className="heading">Next.js on Firebase App Hosting</h1>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied proposal in recent commit.


<section class="features">
<article class="card">
<h2>Server Side Rendering (SSR)</h2>
Expand All @@ -21,22 +20,3 @@ <h2>Deferrable Views</h2>
</p>
</article>
</section>

<section class="links-container">
<div class="links">
<a href="https://firebase.google.com/docs/app-hosting"
>Explore Docs <app-arrow-box
/></a>
<a href="#">See Tutorials <app-arrow-box /></a>
<a href="https://firebase.google.com/docs/cli#apphosting-commands"
>CLI Docs <app-arrow-box
/></a>
<a href="#">Angular Language Service <app-arrow-box /></a>
<a href="#">DevTools <app-arrow-box /></a>
</div>
<div class="links">
<a href="#"><app-github-icon /></a>
<a href="#"><app-twitter-icon /></a>
<a href="#"><app-youtube-icon /></a>
</div>
</section>
41 changes: 1 addition & 40 deletions starters/angular/basic/src/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,39 +244,12 @@ a:hover {
color: var(--secondary-contrast);
letter-spacing: -1%;
}
.link,
.card p a {
color: var(--primary-contrast);
text-decoration: underline;
text-underline-offset: 2px;
}

.links-container {
padding-top: 24px;
display: flex;
flex-wrap: wrap;
gap: 24px;
}

.links {
display: flex;
flex-wrap: wrap;
gap: 10px;
}

.links a {
padding: 14px 15px;
color: var(--primary-contrast);
font-size: 14px;
font-weight: 500;
text-decoration: none;
white-space: nowrap;
justify-content: center;
align-items: center;
gap: 4px;
}

.links a,
.card {
position: relative;
border-radius: 24px;
Expand All @@ -285,7 +258,6 @@ a:hover {
display: flex;
}

.links a::before,
.card::before {
content: '';
position: absolute;
Expand All @@ -299,8 +271,7 @@ a:hover {
pointer-events: none;
}

.card:not(:first-child)::after,
.links a:not(:first-child)::after {
.card:not(:first-child)::after {
content: '';
top: 0;
height: 100%;
Expand All @@ -316,13 +287,6 @@ a:hover {
-webkit-mask: url('assets/between-cards.svg') no-repeat center / contain;
}

.links a:not(:first-child)::after {
width: 30px;
left: calc(-20px);
mask: url('assets/between-links.svg') no-repeat center / contain;
-webkit-mask: url('assets/between-links.svg') no-repeat center / contain;
}

@media only screen and (max-width: 1023px) {
.heading,
.large-heading {
Expand All @@ -338,9 +302,6 @@ a:hover {
}
.top-gradient,
.card::after,
.links a::after {
display: none;
}
.bottom-gradient {
width: 150%;
height: 400px;
Expand Down
Loading