Run Nx + Next.js builds from root context #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blidd-google
requested review from
Yuangwang,
sjjj986,
jamesdaniels and
leoortizz
as code owners
blidd-google
force-pushed
the
blidd-nx-nextjs-root-build
branch
from
b621c32 to
e2d6639
Compare
Yuangwang
reviewed
May 9, 2024
| let cmd = DEFAULT_COMMAND; | ||
| if (process.env.MONOREPO_COMMAND) { | ||
| cmd = process.env.MONOREPO_COMMAND; | ||
| // Determine which command to run the build |
There was a problem hiding this comment.
Could you move this to line 31 right above where its first used?
|
|
||
| // Parse args to pass to the build command | ||
| let cmdArgs: string[] = []; | ||
| if (process.env.MONOREPO_BUILD_ARGS) { |
There was a problem hiding this comment.
Where is MONOREPO build args set? I dont see it anywhere in the buildpacks code either
There was a problem hiding this comment.
MONOREPO_BUILD_ARGS is a new environment variable added in cl/631875763
There was a problem hiding this comment.
Maybe I'm missing something, but I can't seem to find MONOREPO_BUILD_ARGS in that cl. Could you help point me to it?
There was a problem hiding this comment.
Whoops sorry, just uploaded the changes - should be in line 95 of firebasenx/main.go now
Yuangwang
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to #177 for Nx + Next.js builds. One minor difference is that the
FIREBASE_APP_DIRECTORYenvironment variable will still need to be specified, because the server.js file will be located atstandalone/<FIREBASE_APP_DIRECTORY>/server.jsin the .next standalone output directory and we need to specify that path in the bundle.yaml.