Nightly CI Tests #13
Merged
Nightly CI Tests #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarocque
approved these changes
Nov 15, 2024
| ~/.npm | ||
| ${{ github.workspace }}/.next/cache | ||
| # Generate a new cache whenever packages or source files change. | ||
| key: ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }} |
There was a problem hiding this comment.
This is a good idea 🤔
I wonder if I can use this in the SDK repo to re-use archived builds from different commits if there are no source changes. Would cut down the majority of the workflow time.
| with: | ||
| path: | | ||
| ~/.npm | ||
| ${{ github.workspace }}/.next/cache |
There was a problem hiding this comment.
What's in the .next/cache?
There was a problem hiding this comment.
It's a build cache or Next. Nexst complains if you don't use it in CI enviornments, I guess, so I cached it!
| key: ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }} | ||
| # If source files changed but packages didn't, rebuild from a prior cache. | ||
| restore-keys: | | ||
| ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}- |
There was a problem hiding this comment.
I think you accidentally left a hanging - at the end here
There was a problem hiding this comment.
No, it still matches the top key up until the second hasFiles. I actually copied this from "the manual", so it's legit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nightly CI execution of Firebse JS SDK tests exercised by Playwright.
The CI workflow caches:
The CI workflow will run:
workflow_dispatch)Future configuration within the GitHub repo will email the Firebase JS SDK team if there are failures.