From a016f89b9b66fb3e65a71dcaeebd049cef0b41d3 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Thu, 14 Nov 2024 15:30:22 -0500 Subject: [PATCH 01/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 09b447c..6569dae 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -15,6 +15,9 @@ name: Firebase JS SDK Nightly on: + pull_request: + branches: + - main workflow_dispatch: jobs: @@ -28,8 +31,14 @@ jobs: uses: actions/setup-node@v3 with: node-version: 20.x + - name: Write Project Config + env: + PROJECT_CONFIG: ${{ secrets.TEST_PROJECT_CONFIG }} + run: echo "export const firebaseConfig = $PROJECT_CONFIG;" > src/lib/app_tests/firebase.ts - name: Yarn install run: yarn + - name: Yarn build + run: yarn build - name: Launch E2E tests workflow - run: | - echo Hello World (TBD) \ No newline at end of file + run: yarn test + \ No newline at end of file From c782f98c562eaa8bf9caf4c77f9a655c8b5c28d9 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Thu, 14 Nov 2024 15:58:17 -0500 Subject: [PATCH 02/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 6569dae..86d2fc3 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -33,7 +33,7 @@ jobs: node-version: 20.x - name: Write Project Config env: - PROJECT_CONFIG: ${{ secrets.TEST_PROJECT_CONFIG }} + PROJECT_CONFIG: ${{ secrets.PROJECT_CONFIG }} run: echo "export const firebaseConfig = $PROJECT_CONFIG;" > src/lib/app_tests/firebase.ts - name: Yarn install run: yarn From 43234acf41875c13983e60cede68530009178d49 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Thu, 14 Nov 2024 16:28:48 -0500 Subject: [PATCH 03/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 86d2fc3..840b98f 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -39,6 +39,8 @@ jobs: run: yarn - name: Yarn build run: yarn build + - name: Install Playwright browsers + run: npx playwright install --with-deps - name: Launch E2E tests workflow run: yarn test \ No newline at end of file From b545143ffd5db8b3711aa0c9e86b013479ff403f Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 07:54:52 -0500 Subject: [PATCH 04/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 840b98f..b2709bd 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -33,14 +33,16 @@ jobs: node-version: 20.x - name: Write Project Config env: - PROJECT_CONFIG: ${{ secrets.PROJECT_CONFIG }} + PROJECT_CONFIG: ${{ vars.PROJECT }} run: echo "export const firebaseConfig = $PROJECT_CONFIG;" > src/lib/app_tests/firebase.ts + - name: Log + run: cat src/lib/app_tests/firebase.ts - name: Yarn install run: yarn - name: Yarn build run: yarn build - name: Install Playwright browsers - run: npx playwright install --with-deps + run: yarn playwright install --with-deps - name: Launch E2E tests workflow run: yarn test \ No newline at end of file From 27387af3bd58fdd6547a0ae08336ccf6b6ed45a7 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 08:04:21 -0500 Subject: [PATCH 05/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index b2709bd..a51c580 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -33,10 +33,8 @@ jobs: node-version: 20.x - name: Write Project Config env: - PROJECT_CONFIG: ${{ vars.PROJECT }} + PROJECT_CONFIG: ${{ secrets.PROJECT_CONFIG }} run: echo "export const firebaseConfig = $PROJECT_CONFIG;" > src/lib/app_tests/firebase.ts - - name: Log - run: cat src/lib/app_tests/firebase.ts - name: Yarn install run: yarn - name: Yarn build From dd7b83774da0dc80e77e2a432886793dbf6eda07 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 10:43:19 -0500 Subject: [PATCH 06/16] caching --- .github/workflows/nightly-js-sdk.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index a51c580..08397d4 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -28,15 +28,23 @@ jobs: - name: Checkout Repo uses: actions/checkout@v4 - name: Set up Node (20) - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: 20.x + cache: 'npm' + cache-dependency-path: yarn.lock + - name: Restore cached node_modules + uses: actions/cache@v4 + id: node_modules + with: + path: "./node_modules" + key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }} - name: Write Project Config env: PROJECT_CONFIG: ${{ secrets.PROJECT_CONFIG }} run: echo "export const firebaseConfig = $PROJECT_CONFIG;" > src/lib/app_tests/firebase.ts - name: Yarn install - run: yarn + run: yarn --frozen-lockfile - name: Yarn build run: yarn build - name: Install Playwright browsers From 9694f4556f677a4e15c24825c5e01d95f18df561 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 10:54:38 -0500 Subject: [PATCH 07/16] yarn build cache --- .github/workflows/nightly-js-sdk.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 08397d4..a4f75d2 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -45,6 +45,17 @@ jobs: run: echo "export const firebaseConfig = $PROJECT_CONFIG;" > src/lib/app_tests/firebase.ts - name: Yarn install run: yarn --frozen-lockfile + - name: Restore yarn build cache + uses: actions/cache@v4 + with: + path: | + ~/.npm + ${{ github.workspace }}/.next/cache + # Generate a new cache whenever packages or source files change. + key: ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }} + # If source files changed but packages didn't, rebuild from a prior cache. + restore-keys: | + ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}- - name: Yarn build run: yarn build - name: Install Playwright browsers From 2bfb1b0610191ededfbeb032a4a20040cb1f9614 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 11:18:40 -0500 Subject: [PATCH 08/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index a4f75d2..2d8e9db 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -48,11 +48,11 @@ jobs: - name: Restore yarn build cache uses: actions/cache@v4 with: - path: | - ~/.npm - ${{ github.workspace }}/.next/cache - # Generate a new cache whenever packages or source files change. - key: ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }} + path: | + ~/.npm + ${{ github.workspace }}/.next/cache + # Generate a new cache whenever packages or source files change. + key: ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }} # If source files changed but packages didn't, rebuild from a prior cache. restore-keys: | ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}- From 79943e845b6389ea80c95a854cc665eafa07df99 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 11:19:16 -0500 Subject: [PATCH 09/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 2d8e9db..520c058 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -53,9 +53,9 @@ jobs: ${{ github.workspace }}/.next/cache # Generate a new cache whenever packages or source files change. key: ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }} - # If source files changed but packages didn't, rebuild from a prior cache. - restore-keys: | - ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}- + # If source files changed but packages didn't, rebuild from a prior cache. + restore-keys: | + ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}- - name: Yarn build run: yarn build - name: Install Playwright browsers From 3c4974a1dcaf1dfca7ec7e77b2d4a02da5b3f102 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 11:37:32 -0500 Subject: [PATCH 10/16] playwright cache --- .github/workflows/nightly-js-sdk.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 520c058..265f85a 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -58,6 +58,11 @@ jobs: ${{ runner.os }}-nextjs-${{ hashFiles('yarn.lock') }}- - name: Yarn build run: yarn build + - name: Restore cached playwright browsers + uses: actions/cache@v4 + with: + path: ~/.cache/ms-playwright + key: playwright-${{ hashFiles('playwright.config.ts') }} - name: Install Playwright browsers run: yarn playwright install --with-deps - name: Launch E2E tests workflow From eb9660cdbda191065f2f0925d7a382d659de89cd Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 11:38:37 -0500 Subject: [PATCH 11/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 265f85a..7baa279 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -60,9 +60,9 @@ jobs: run: yarn build - name: Restore cached playwright browsers uses: actions/cache@v4 - with: - path: ~/.cache/ms-playwright - key: playwright-${{ hashFiles('playwright.config.ts') }} + with: + path: ~/.cache/ms-playwright + key: playwright-${{ hashFiles('playwright.config.ts') }} - name: Install Playwright browsers run: yarn playwright install --with-deps - name: Launch E2E tests workflow From 94ced57474c63328a7c8c77934d0b6cac72fca3e Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 11:39:25 -0500 Subject: [PATCH 12/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 7baa279..1f8a397 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -59,10 +59,10 @@ jobs: - name: Yarn build run: yarn build - name: Restore cached playwright browsers - uses: actions/cache@v4 - with: - path: ~/.cache/ms-playwright - key: playwright-${{ hashFiles('playwright.config.ts') }} + uses: actions/cache@v4 + with: + path: ~/.cache/ms-playwright + key: playwright-${{ hashFiles('playwright.config.ts') }} - name: Install Playwright browsers run: yarn playwright install --with-deps - name: Launch E2E tests workflow From 696427c00198a8583546d90cc89c7227ba8a96bb Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 11:58:51 -0500 Subject: [PATCH 13/16] Update nightly-js-sdk.yaml --- .github/workflows/nightly-js-sdk.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 1f8a397..ffd05e1 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -59,11 +59,13 @@ jobs: - name: Yarn build run: yarn build - name: Restore cached playwright browsers + id: playwright-cache uses: actions/cache@v4 with: path: ~/.cache/ms-playwright key: playwright-${{ hashFiles('playwright.config.ts') }} - name: Install Playwright browsers + if: steps.playwright-cache.outputs.cache-hit != 'true' run: yarn playwright install --with-deps - name: Launch E2E tests workflow run: yarn test From 50033970f24bedb23aca473d9eb535730024277d Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 13:23:56 -0500 Subject: [PATCH 14/16] playwright needs to be installed despite cache. --- .github/workflows/nightly-js-sdk.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index ffd05e1..1f8a397 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -59,13 +59,11 @@ jobs: - name: Yarn build run: yarn build - name: Restore cached playwright browsers - id: playwright-cache uses: actions/cache@v4 with: path: ~/.cache/ms-playwright key: playwright-${{ hashFiles('playwright.config.ts') }} - name: Install Playwright browsers - if: steps.playwright-cache.outputs.cache-hit != 'true' run: yarn playwright install --with-deps - name: Launch E2E tests workflow run: yarn test From 89da17e910889f321a6681f185a068aeadae28d2 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 13:34:46 -0500 Subject: [PATCH 15/16] cron job --- .github/workflows/nightly-js-sdk.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 1f8a397..49efa15 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -15,6 +15,8 @@ name: Firebase JS SDK Nightly on: + schedule: + - cron: "0 0 * * *" pull_request: branches: - main From 4026b636750503a4b80a6e3904bd059b030f60cc Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 15 Nov 2024 13:38:43 -0500 Subject: [PATCH 16/16] newline --- .github/workflows/nightly-js-sdk.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/nightly-js-sdk.yaml b/.github/workflows/nightly-js-sdk.yaml index 49efa15..dd194f9 100644 --- a/.github/workflows/nightly-js-sdk.yaml +++ b/.github/workflows/nightly-js-sdk.yaml @@ -24,7 +24,7 @@ on: jobs: run: - name: Execute tests + name: Execute JS SDK Playwright tests runs-on: ubuntu-latest steps: - name: Checkout Repo @@ -69,4 +69,3 @@ jobs: run: yarn playwright install --with-deps - name: Launch E2E tests workflow run: yarn test - \ No newline at end of file