Fix #7269: Restore deferred primary key indexes #8170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed database recovery aborting on the first failure of the first problematic deferred index gbak (FirebirdSQL#7269)
GeF0rs
changed the title
Contributor
Author
|
? |
Member
|
What about extracting code, copied from "creating FK" block below, into separate routine to avoid duplication ? |
Extracted "activateIndex" function to remove duplicate code when restoring the database
Contributor
Author
|
I moved the activation of indexes into a separate function, please take a look |
Contributor
Author
|
? |
Member
|
Please, be patient and wait a bit, I'll return to it when time permits. |
Member
|
I will add some additional fix after merge. |
Contributor
|
JFYI: You can create a pull request to a pull request improving it before merging. |
Member
Yes. But it is too much bureaucracy and not needed in this case. |
hvlad
added a commit
that referenced
this pull request
Oct 24, 2024
hvlad
pushed a commit
that referenced
this pull request
Oct 24, 2024
* fixed restore deferred primary key indexes Fixed database recovery aborting on the first failure of the first problematic deferred index gbak (#7269) * Extract function activateIndex Extracted "activateIndex" function to remove duplicate code when restoring the database
hvlad
added a commit
that referenced
this pull request
Oct 24, 2024
Contributor
Author
|
Thank you for accepting my fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed database recovery aborting on the first failure of the first problematic deferred index gbak (#7269)
I took the database to check from #7269
Previously, recovery was interrupted when trying to activate PK_A3.
Now the recovery continues, which allows you to smoothly restore PK_A2.
The foreign key, however, is still not restored because requires an active primary key, but this still allows you to greatly reduce the number of non-activated indexes (on our industrial base, 3000+ indexes were not activated due to one non-activated one)