Fix lint warnings

Author: FliegendeWurst

app/build.gradle

@@ -109,7 +109,7 @@ tasks.register("jacocoTestReport", JacocoReport) {
     }
 
     def fileFilter = ["**/R.class", '**/R$*.class', "**/BuildConfig.*", "**/Manifest*.*", "**/*Test*.*", "android/**/*.*", "**/Icon.*"]
-    def debugTree = fileTree(dir: "${buildDir}/tmp/kotlin-classes/debug", excludes: fileFilter)
+    def debugTree = fileTree(dir: "${layout.buildDirectory}/tmp/kotlin-classes/debug", excludes: fileFilter)
     def mainSrc = "${project.projectDir}/src/main/kotlin"
 
     sourceDirectories.from = files([mainSrc])

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/activity/SetupActivity.kt

@@ -1,6 +1,5 @@
 package eu.fliegendewurst.triliumdroid.activity
 
-import android.app.Activity
 import android.app.UiModeManager
 import android.content.Intent
 import android.os.Build
@@ -136,7 +135,7 @@ class SetupActivity : AppCompatActivity() {
 
 		val exportLauncher =
 			registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { result ->
-				if (result.resultCode != Activity.RESULT_OK) {
+				if (result.resultCode != RESULT_OK) {
 					return@registerForActivityResult
 				}
 				contentResolver.openOutputStream(

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/sync/Sync.kt

@@ -316,9 +316,7 @@ object Sync {
 					)
 					if (outstandingPullCount > 0) {
 						callbackOutstanding(outstandingPullCount)
-						runBlocking {
-							sync(totalSynced, callbackOutstanding, callbackError, callbackDone)
-						}
+						sync(totalSynced, callbackOutstanding, callbackError, callbackDone)
 					} else {
 						callbackDone(Pair(totalSynced, totalPushed))
 					}

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/util/CookieJar.kt

@@ -18,7 +18,7 @@ class CookieJar : CookieJar {
 	override fun saveFromResponse(url: HttpUrl, cookies: List<Cookie>) {
 		val host = url.host
 		val cookieStore =
-			cookieStorage.computeIfAbsent(host, { return@computeIfAbsent mutableListOf() })
+			cookieStorage.computeIfAbsent(host) { return@computeIfAbsent mutableListOf() }
 		for (cookie in cookies) {
 			Log.i(
 				TAG,

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/widget/NoteWidget.kt

@@ -18,6 +18,7 @@ import android.util.TypedValue
 import android.view.View
 import android.widget.RemoteViews
 import androidx.core.content.res.ResourcesCompat
+import androidx.core.graphics.createBitmap
 import eu.fliegendewurst.triliumdroid.R
 import eu.fliegendewurst.triliumdroid.activity.main.HistoryItem
 import eu.fliegendewurst.triliumdroid.activity.main.MainActivity
@@ -207,8 +208,7 @@ private suspend fun updateAppWidget(
 }
 
 fun renderIcon(context: Context, width: Float, height: Float, icon: String): Bitmap {
-	val myBitmap =
-		Bitmap.createBitmap(width.roundToInt(), height.roundToInt(), Bitmap.Config.ARGB_8888)
+	val myBitmap = createBitmap(width.roundToInt(), height.roundToInt())
 	val myCanvas = Canvas(myBitmap)
 	val paint = Paint()
 	val typeface = ResourcesCompat.getFont(context, R.font.boxicons)

app/src/main/res/drawable-v21/app_widget_background.xml renamed to app/src/main/res/drawable/app_widget_background.xml

@@ -1,25 +1,30 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content"
     android:background="@drawable/border_attribute"
     android:contentDescription="@string/attribute"
     android:orientation="horizontal">
 
+    <!-- "hardcoded" text is always replaced by dynamic values -->
+
     <TextView
         android:id="@+id/label_attribute_name"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginStart="2dp"
         android:layout_marginEnd="2dp"
         android:labelFor="@id/label_attribute_value"
-        android:text="Name" />
+        android:text="Name"
+        tools:ignore="HardcodedText" />
 
     <EditText
         android:id="@+id/label_attribute_value"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:inputType="text"
         android:importantForAutofill="no"
-        android:text="Value" />
-</LinearLayout>
+        android:text="Value"
+        tools:ignore="HardcodedText" />
+</LinearLayout>

app/src/main/res/drawable-v21/app_widget_inner_view_background.xml renamed to app/src/main/res/drawable/app_widget_inner_view_background.xml

@@ -22,6 +22,7 @@
         android:background="@color/primary"
         android:baselineAligned="false"
         android:clickable="true"
+        android:focusable="true"
         android:elevation="2dp"
         android:orientation="horizontal"
         android:padding="@dimen/medium_margin">

app/src/main/res/layout/item_attribute.xml

@@ -1,4 +1,4 @@
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools">
     <string name="app_name">Trilium Notes</string>
     <string name="server_placeholder" translatable="false">https://example.trilium.cc</string>
     <string name="user_placeholder">Username</string>
@@ -148,9 +148,9 @@
     <string name="open_note">Open note</string>
     <string name="title_trust_sync_server_certificate">Trust sync server certificate?</string>
     <string name="snackbar_sync_start">Sync: starting…</string>
-    <string name="snackbar_sync_progress">Sync: %1$d outstanding…</string>
+    <string name="snackbar_sync_progress" tools:ignore="PluralsCandidate">Sync: %1$d outstanding…</string>
     <string name="snackbar_sync_error">Sync: error!</string>
-    <string name="snackbar_sync_done">Sync: %1$d pulled, %2$d pushed</string>
+    <string name="snackbar_sync_done" tools:ignore="PluralsCandidate">Sync: %1$d pulled, %2$d pushed</string>
     <string name="sidebar_tab_1">Notes</string>
     <string name="sidebar_tab_2">Special</string>
     <string name="title_dialog_delete_note">Delete note</string>

app/src/main/res/layout/item_navigation_button.xml

@@ -70,13 +70,7 @@
         <item name="android:paddingRight">@dimen/bigger_margin</item>
     </style>
 
-    <style name="Widget.TriliumDroid.AppWidget.Container" parent="android:Widget">
-        <item name="android:id">@android:id/background</item>
-        <item name="android:background">?android:attr/colorBackground</item>
-    </style>
+    <style name="Widget.TriliumDroid.AppWidget.Container" parent="android:Widget"></style>
 
-    <style name="Widget.TriliumDroid.AppWidget.InnerView" parent="android:Widget">
-        <item name="android:background">?android:attr/colorPrimary</item>
-        <item name="android:textColor">?android:attr/textColorPrimary</item>
-    </style>
+    <style name="Widget.TriliumDroid.AppWidget.InnerView" parent="android:Widget"></style>
 </resources>

app/src/main/res/mipmap-v24/ic_launcher.png renamed to app/src/main/res/mipmap/ic_launcher.png

@@ -5,7 +5,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.9.1'
+        classpath 'com.android.tools.build:gradle:8.9.2'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:2.1.20'
 
         // NOTE: Do not place your application dependencies here; they belong