-
Notifications
You must be signed in to change notification settings - Fork 37
feat: Added support for on the fly certificates #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ertaining to order that allows for multiple certificates and adding new certificates on the fly
8150f49
to
4db96c9
Compare
Interesting. I'm going on vacation tomorrow until the 23rd, so review may have to wait until then. Could you outline the goals and targeted usecases in a few lines here, especially with respect to: |
I suspect I would like to merge features/refactors one-by-one, but I should review what you submitted a bit before commenting on the granularity in more detail. |
Coexistence is supported: Rate limits for new certs per domain are not taken in account because new certificates are up to the user. To create a new cert with any amount of domains: The user has full control over the number of certificates and the number of domains. For now the system errors if there is a domain overlap between certificates, but it could be supported with minor changes. For rate limiting reasons orders are done sequentially and stops the creation/updates if an error occurs, completed updates are still applied in case of errors. Wildcard certificates are not yet supported. |
now all that is left is testing in real world conditions, integrating it with the rest of the crate, renaming the structures to better names and documenting the functionnalities. |
# Conflicts: # src/acceptor.rs
I just tested it in production, however there is this error i'm getting one one of the domains: EDIT: I was sending the identifiers instead of the authorizations like a dummy... |
I can confirm it works like a charm in production. Tell me how you would like to proceed. |
I'm back home now. I'll try to find time to look a this in detail this week. |
a9704ac
to
f8eee23
Compare
Ongoing fix for #47