Skip to content

Conversation

@Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Sep 26, 2024

Description

Groups tooltips on line type charts using the interactions options

NOTES:

  • I wrapped the call to this.chart.update into a chartUpdate method so that we can debounce the multiple calls generated by property updates (the props are watched individually)
    • I then noted we dont actually support dynamic prop updates 🤦‍♂️ BUT I left it in as dynamic updates are listed as a TODO and this will avoid unnecessary chart update calls.
  • I added some debugging where I add the chart object to the window object so that during debugging, I can see the actual config and data applied to the chart. This was super useful. So instead of deleting it, I let it in commented with a note for future devs to take advantage of. fee free to remove it.

Related Issue(s)

#1254

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from joepavitt September 26, 2024 12:09
@Steve-Mcl
Copy link
Contributor Author

NOTE: I will add tests for this once #1331 is merged.

@Steve-Mcl Steve-Mcl linked an issue Sep 29, 2024 that may be closed by this pull request
Co-authored-by: Joe Pavitt <99246719+joepavitt@users.noreply.github.com>
@Steve-Mcl Steve-Mcl requested a review from joepavitt October 1, 2024 16:56
@Steve-Mcl
Copy link
Contributor Author

Merged your correction to the mode and addition for scatter. Ta.
I will need to update tests to pick up additional grouping chart type for the above.

Addressed you comment about window.uiChart in comment here: #1336 (comment)

@Steve-Mcl
Copy link
Contributor Author

Tests updated/added to cover changes for scatter and bar.

All passing bar one of the control spec tests (usual suspect) (really would love to get that reliable!)

@joepavitt
Copy link
Contributor

(really would love to get that reliable!)

@Steve-Mcl - @cstns and I have collectively spent days trying - we've given up.

@joepavitt
Copy link
Contributor

Works great - thanks @Steve-Mcl

@joepavitt joepavitt merged commit ee584f1 into main Oct 2, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 1254-tooltip-grouping branch October 2, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hover to show all topics in x property value when hovering

3 participants