fix: add default/fallback value with null-coalesce operator

das-nagnag · bwaidelich · commit 8dca0f7f359d · 2024-07-15T15:16:22.000+02:00
diff --git a/Classes/Job/JobManager.php b/Classes/Job/JobManager.php
@@ -123,7 +123,7 @@ public function waitAndExecute(string $queueName, $timeout = null): ?Message
             if (isset($queueSettings['executeIsolated']) && $queueSettings['executeIsolated'] === true) {
                 $messageCacheIdentifier = sha1(serialize($message));
                 $this->messageCache->set($messageCacheIdentifier, $message);
-                Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, $queueSettings['outputResults'], ['queue' => $queue->getName(), 'messageCacheIdentifier' => $messageCacheIdentifier]);
+                Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, $queueSettings['outputResults'] ?? false, ['queue' => $queue->getName(), 'messageCacheIdentifier' => $messageCacheIdentifier]);
             } else {
                 $this->executeJobForMessage($queue, $message);
             }

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public function waitAndExecute(string $queueName, $timeout = null): ?Message`
`123`	`123`	`if (isset($queueSettings['executeIsolated']) && $queueSettings['executeIsolated'] === true) {`
`124`	`124`	`$messageCacheIdentifier = sha1(serialize($message));`
`125`	`125`	`$this->messageCache->set($messageCacheIdentifier, $message);`
`126`		`- Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, $queueSettings['outputResults'], ['queue' => $queue->getName(), 'messageCacheIdentifier' => $messageCacheIdentifier]);`
	`126`	`+ Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, $queueSettings['outputResults'] ?? false, ['queue' => $queue->getName(), 'messageCacheIdentifier' => $messageCacheIdentifier]);`
`127`	`127`	`} else {`
`128`	`128`	`$this->executeJobForMessage($queue, $message);`
`129`	`129`	`}`