Skip to content
This repository was archived by the owner on Oct 30, 2023. It is now read-only.

Commit f9f3b55

Browse files
authored
Merge pull request #491 from FlowzPlatform/ComponentImportChange
dynamic component loading
2 parents 7ce4e58 + b984910 commit f9f3b55

File tree

14 files changed

+24
-49
lines changed

14 files changed

+24
-49
lines changed

client/src/components/ListInstances.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
</tr>
1818
</thead>
1919
<tbody>
20-
<tr v-for="(item, inx) in instanceEntries">
20+
<tr v-for="(item, inx) in instanceEntries" :key="inx">
2121
<td>{{item.id}}</td>
2222
<td>
2323
<Tag color="blue" type="border" class="uppercase">{{item.mainStatus}}</Tag>

client/src/components/SchemaSubForm.vue

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,6 @@
204204
</template>
205205
<script>
206206
import $ from 'jquery'
207-
import SchemaSubForm from './SchemaSubForm'
208-
import SchemaSubFormView from './SchemaSubFormView'
209-
// import axios from 'axios'
210207
import moment from 'moment'
211208
import _ from 'lodash'
212209
import schemaModel from '@/api/schema'
@@ -230,8 +227,8 @@ export default {
230227
}
231228
},
232229
components: {
233-
schemasubform: SchemaSubForm,
234-
SchemaSubFormView: SchemaSubFormView
230+
schemasubform: (resolve) => { require(['./SchemaSubForm'], resolve) },
231+
SchemaSubFormView: (resolve) => { require(['./SchemaSubFormView'], resolve) }
235232
},
236233
methods: {
237234
async handleFileChange (e, index, fieldName) {

client/src/components/SchemaSubFormView.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@
6363

6464
<script>
6565
import schemaModel from '@/api/schema'
66-
import SchemaSubFormView from './SchemaSubFormView'
67-
// import axios from 'axios'
6866
6967
var AWS = require('aws-sdk')
7068
AWS.config.update({
@@ -81,7 +79,7 @@ export default {
8179
}
8280
},
8381
components: {
84-
'schemasubformView': SchemaSubFormView
82+
'schemasubformView': (resolve) => { require(['./SchemaSubFormView'], resolve) }
8583
},
8684
methods: {
8785
getStyle (field) {

client/src/components/SchemaView.vue

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,8 @@
158158
import _ from 'lodash'
159159
import $ from 'jquery'
160160
161-
import ListInstances from './ListInstances'
162-
import SchemaSubForm from './SchemaSubForm'
163-
import SchemaSubFormView from './SchemaSubFormView'
164-
import email from './email'
165-
166161
import flowzdataModal from '@/api/flowzdata'
167162
import flowzModel from '@/api/flowz'
168-
169-
import schemalist from '@/pages/user/SchemaList'
170163
import schemaModel from '@/api/schema'
171164
172165
import finstanceModal from '@/api/finstance'
@@ -238,11 +231,11 @@ export default {
238231
}
239232
},
240233
components: {
241-
'list-instances': ListInstances,
242-
'schemasubform': SchemaSubForm,
243-
'schemalist': schemalist,
244-
'email': email,
245-
'schemasubformview': SchemaSubFormView
234+
'list-instances': (resolve) => { require(['./ListInstances'], resolve) },
235+
'schemasubform': (resolve) => { require(['./SchemaSubForm'], resolve) },
236+
'schemalist': (resolve) => { require(['@/pages/user/SchemaList'], resolve) },
237+
'email': (resolve) => { require(['./email'], resolve) },
238+
'schemasubformview': (resolve) => { require(['./SchemaSubFormView'], resolve) }
246239
},
247240
methods: {
248241
searchData (query) {
@@ -889,7 +882,6 @@ export default {
889882
890883
getSchema () {
891884
return schemaModel.getAll(this.flowzData.schema).then(res => {
892-
console.log(res)
893885
return res
894886
}).catch(err => {
895887
console.log('Error: ', err)

client/src/components/cellRender.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@
7575
import moment from 'moment'
7676
import flowzdataModal from '@/api/flowzdata'
7777
import schemaModel from '@/api/schema'
78-
import SchemaSubFormView from './SchemaSubFormView'
7978
8079
export default {
8180
name: 'CellRender',
@@ -93,7 +92,7 @@ export default {
9392
}
9493
},
9594
components: {
96-
'schemasubformview': SchemaSubFormView
95+
'schemasubformview': (resolve) => { require(['./SchemaSubFormView'], resolve) }
9796
},
9897
filters: {
9998
getAgoStatus (item) {

client/src/components/email.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ import schemaModel from '@/api/schema'
7070
// }
7171
},
7272
components: {
73-
'editor': function (resolve) { require(['@tinymce/tinymce-vue'], resolve)},
74-
'schemasubform': function (resolve) { require(['./SchemaSubForm'], resolve)}
73+
'editor': (resolve) => { require(['@tinymce/tinymce-vue'], resolve) },
74+
'schemasubform': (resolve) => { require(['./SchemaSubForm'], resolve) }
7575
},
7676
props: {
7777
'btnArr': Object,

client/src/components/emailtemplate.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
</template>
2424

2525
<script>
26-
import Editor from '@tinymce/tinymce-vue'
2726
import saveemailTemplate from '@/api/emailtemplate'
2827
import _ from 'lodash'
2928
@@ -108,7 +107,7 @@ export default {
108107
}
109108
},
110109
components: {
111-
'editor': Editor
110+
'editor': (resolve) => { require(['@tinymce/tinymce-vue'], resolve) }
112111
},
113112
methods: {
114113
saveTemplate () {

client/src/masterLayout/Header.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,9 @@
8181
</template>
8282
<script>
8383
import psl from 'psl'
84-
// import axios from 'axios'
85-
import subscription from '@/components/subscription'
8684
export default {
8785
components: {
88-
subscription
86+
subscription: (resolve) => { require(['@/components/subscription'], resolve) }
8987
},
9088
computed: {
9189
getRole () {

client/src/masterLayout/Master.vue

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,12 @@
1818
</template>
1919

2020
<script>
21-
import Header from './Header'
22-
import SideBar from './SideBar'
23-
import Footer from './Footer'
2421
export default {
2522
name: 'app',
2623
components: {
27-
'f-sidebar': SideBar,
28-
'f-header': Header,
29-
'f-footer': Footer
24+
'f-sidebar': (resolve) => { require(['./SideBar'], resolve) },
25+
'f-header': (resolve) => { require(['./Header'], resolve) },
26+
'f-footer': (resolve) => { require(['./Footer'], resolve) }
3027
},
3128
data () {
3229
return {}

client/src/pages/flow/List.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ import finstanceModal from '@/api/finstance'
170170
import axios from 'axios'
171171
import viewSVG from './viewSVG'
172172
import psl from 'psl'
173-
import subscription from '@/components/subscription'
173+
// import subscription from '@/components/subscription'
174174
175175
import config from '@/config'
176176
import expandRow2 from './assigned_invite_table-expand.vue'
@@ -184,9 +184,9 @@ import moment from 'moment'
184184
export default {
185185
name: 'Flowz',
186186
components: {
187-
'viewSVG': viewSVG,
188-
expandRow2,
189-
subscription
187+
'viewSVG': (resolve) => { require(['./viewSVG'], resolve) },
188+
expandRow2: (resolve) => { require(['./assigned_invite_table-expand.vue'], resolve) },
189+
subscription: (resolve) => { require(['@/components/subscription'], resolve) }
190190
},
191191
data () {
192192
return {

0 commit comments

Comments
 (0)