Skip to content

Add a variant of Adam called "PAdam" #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add a variant of Adam called "PAdam" #2273

wants to merge 1 commit into from

Conversation

4SAnalyticsnModelling
Copy link

@4SAnalyticsnModelling 4SAnalyticsnModelling commented Jun 21, 2023

Add a variant of Adam optimizer called "partially adaptive momentum estimation method (PAdam)"

Add a new variant of Adam optimizer called "partially adaptive momentum estimation method (PAdam)"
@4SAnalyticsnModelling 4SAnalyticsnModelling changed the title Update Optimise.jl Add a new variant of Adam optimizer called "partially adaptive momentum estimation method (PAdam)" Jun 21, 2023
@4SAnalyticsnModelling 4SAnalyticsnModelling changed the title Add a new variant of Adam optimizer called "partially adaptive momentum estimation method (PAdam)" Add a variant of Adam called "PAdam" Jun 21, 2023
@CarloLucibello
Copy link
Member

why did you open so many PRs?

@mcabbott
Copy link
Member

When I looked the most meat was in #2276 . The others should be commits on that branch, not indep. PRs.

@4SAnalyticsnModelling
Copy link
Author

4SAnalyticsnModelling commented Jun 29, 2023

@CarloLucibello, I apologize for creating confusion with so many PRs! As @mcabbott mentioned, they are all related PRs. While #2276 has most of the meat, the other commits are also required to make the changes work (i.e. they are not independent). I wasn't sure how to include all of those changes in one PR (since the proposed changes were in different files), that's why I went to create so many of them.

@mcabbott
Copy link
Member

Somehow you need to push more commits to the same branch, which will update the PR. It's generally easiest to do things on your computer, rather than on github's website... I'm not sure I know how to move commits using the website, but this is called git cherry-pick locally. These things are confusing at first but soon become second nature.

I like this guide but not sure it's the ideal reference:

https://kshyatt.github.io/post/firstjuliapr/

@4SAnalyticsnModelling
Copy link
Author

4SAnalyticsnModelling commented Jun 29, 2023

Thanks @mcabbott! I'll follow the article and give it a try to see if I can make all related commits to one branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants