ACPI: Prefer ACPI 2.0 over 1.0 table #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, it would be random depending on table order.
|
Given that we are mostly targeting legacy OS maybe 1.0 should be prefered? |
|
Ideally, yes. In practice, the reason why I defaulted to ACPI 2.0 is because, on modern systems, ACPI 1.0 stuff may be broken (I consulted about this very thing with the uACPI maintainer). That may also be the reason why some people have been having ACPI issues on Windows XP, but I am unsure. |
|
The uACPI maintainer has also said that, on x86 systems, it is really unlikely to have (he's never seen) tables above 4G, despite using the XSDT, so this should not be an issue anyways. |
|
Makes sense, then, LGTM! Maybe this should be configurable after I implement configuration mechanism, alas. |
mintsuki
added a commit
to mintsuki/csmwrap
that referenced
this pull request
Jun 16, 2025
This mirrors PR FlyGoat#70, done for similar reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, it would be random depending on table order.