Skip to content

Conversation

mintsuki
Copy link
Collaborator

No description provided.

@FlyGoat FlyGoat merged commit 8f4c516 into FlyGoat:main Jun 16, 2025
1 check passed
@FlyGoat
Copy link
Owner

FlyGoat commented Jun 16, 2025

Oh I just realised we should not do this, SeaVGABIOS relies on this as well.

@FlyGoat
Copy link
Owner

FlyGoat commented Jun 16, 2025

Reverted.

@mintsuki mintsuki deleted the no-oprom-table-init-if-no-oprom branch June 16, 2025 12:23
@mintsuki
Copy link
Collaborator Author

So, SeaVGABIOS relies on doing this with null pointers to the OpROM?

@FlyGoat
Copy link
Owner

FlyGoat commented Jun 16, 2025

@mintsuki Nah it's not null pointer.

priv.low_stub->vga_oprom_table.OpromSegment = EFI_SEGMENT(VGABIOS_START);

It will always run OpROM at 0xC00000. We copied SeaVGABIOS here before.

@mintsuki
Copy link
Collaborator Author

Oh, my bad, sorry. I hadn't noticed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants