Revert "Import uACPI" #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5321655.
|
My plan is to uACPI for #11, also we need to handle MCFG table given that we know IOPort based PCI access is somewhat broken on a couple of platforms. |
|
Understandable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5321655.
There isn't a real need to have uACPI if we're not planning on ever using anything past its barebones mode (which atm we are not even using).
The PCI BAR reallocation and the need to discover root buses, as far as I can tell, is fulfilled just fine by UEFI alone with its root bridge I/O protocol.
This isn't because there is anything wrong with uACPI, of course, it's just because it's sort of pointless to have something we don't need around just to bloat the binary size and to have extra (mostly dead) code around.