fix(firestore): Indices and better error handling

Author: grimsteel

firestore.indexes.json

@@ -41,7 +41,7 @@
             "queryScope": "COLLECTION",
             "fields": [
                 {
-                    "fieldPath": "visibility",
+                    "fieldPath": "uid",
                     "order": "ASCENDING"
                 },
                 {
@@ -59,8 +59,8 @@
                     "order": "ASCENDING"
                 },
                 {
-                    "fieldPath": "uid",
-                    "order": "ASCENDING"
+                    "fieldPath": "likes",
+                    "order": "DESCENDING"
                 }
             ]
         },
@@ -75,23 +75,23 @@
                 {
                     "fieldPath": "uid",
                     "order": "ASCENDING"
-                },
-                {
-                    "fieldPath": "likes",
-                    "order": "DESCENDING"
                 }
             ]
         },
         {
             "collectionGroup": "sets",
             "queryScope": "COLLECTION",
             "fields": [
+                {
+                    "fieldPath": "visibility",
+                    "order": "ASCENDING"
+                },
                 {
                     "fieldPath": "uid",
                     "order": "ASCENDING"
                 },
                 {
-                    "fieldPath": "creationTime",
+                    "fieldPath": "likes",
                     "order": "DESCENDING"
                 }
             ]
@@ -129,12 +129,6 @@
             "ttl": false,
             "indexes": []
         },
-        {
-            "collectionGroup": "sets",
-            "fieldPath": "name",
-            "ttl": false,
-            "indexes": []
-        },
         {
             "collectionGroup": "sets",
             "fieldPath": "description",

src/js/firebase-rest-api/firestore.ts

@@ -66,9 +66,9 @@ export const Firestore = {
             headers: getRequestHeaders(idToken),
             body: JSON.stringify({ structuredQuery })
         });
-        const json: {document: FirestoreRestDocument, done: boolean, }[] & FirestoreRestError = await res.json();
-        if ("error" in json && json.error) throwResponseError(json.error);
-        if (json.length === 1 && json[0].done && !json[0].document) return [];
+        const json: ({document: FirestoreRestDocument, done: boolean } & FirestoreRestError)[] = await res.json();
+        if ("error" in json[0] && json[0].error) throwResponseError(json[0].error);
+        if (json.length === 1 && !json[0].document) return [];
         return json.map((info) => {
             const docObj: ParsedRestDocument = {
                 pathParts: info.document.name.split("/"),