Skip to content

Conversation

scottrippey
Copy link
Member

This is to fix the build issues on main

Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 2e1cabc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 7:47am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses build issues on the main branch by upgrading the Wireit cache version and updating module imports to align with the newer APIs.

  • Updates the Wireit caching version to v2 in GitHub workflow files
  • Changes ReactDOM import to use "react-dom/client" in the one-page template
  • Refactors import map generation in the one-page generator to only iterate over dependencies

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/create-spectacle/src/templates/one-page.ts Updates ReactDOM import for compatibility with React 18+
packages/create-spectacle/src/generators/one-page.ts Refactors importMap generation and importUrl helper; introduces DEVELOPMENT_BUILDS flag
packages/create-spectacle/src/cli.ts Updates type definition for progressInterval
.github/workflows/create-spectacle.yml Upgrades Wireit cache action to v2
.github/workflows/ci.yml Upgrades Wireit cache action to v2
Files not reviewed (3)
  • .nvmrc: Language not supported
  • package.json: Language not supported
  • packages/create-spectacle/package.json: Language not supported
Comments suppressed due to low confidence (1)

packages/create-spectacle/src/generators/one-page.ts:9

  • Removing the iteration over peerDependencies may cause required packages to be omitted from the import map. Please verify that none of the packages listed solely in peerDependencies are needed for the build.
const { dependencies, peerDependencies } = spectaclePackage;

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scottrippey scottrippey merged commit ddc2fc3 into main Apr 17, 2025
5 checks passed
@scottrippey scottrippey deleted the wireit-cache-fix branch April 17, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants