-
Notifications
You must be signed in to change notification settings - Fork 698
Fix: fixed builds by upgrading wireit cache #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses build issues on the main branch by upgrading the Wireit cache version and updating module imports to align with the newer APIs.
- Updates the Wireit caching version to v2 in GitHub workflow files
- Changes ReactDOM import to use "react-dom/client" in the one-page template
- Refactors import map generation in the one-page generator to only iterate over dependencies
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/create-spectacle/src/templates/one-page.ts | Updates ReactDOM import for compatibility with React 18+ |
packages/create-spectacle/src/generators/one-page.ts | Refactors importMap generation and importUrl helper; introduces DEVELOPMENT_BUILDS flag |
packages/create-spectacle/src/cli.ts | Updates type definition for progressInterval |
.github/workflows/create-spectacle.yml | Upgrades Wireit cache action to v2 |
.github/workflows/ci.yml | Upgrades Wireit cache action to v2 |
Files not reviewed (3)
- .nvmrc: Language not supported
- package.json: Language not supported
- packages/create-spectacle/package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/create-spectacle/src/generators/one-page.ts:9
- Removing the iteration over peerDependencies may cause required packages to be omitted from the import map. Please verify that none of the packages listed solely in peerDependencies are needed for the build.
const { dependencies, peerDependencies } = spectaclePackage;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is to fix the build issues on
main