Skip to content

Fix: Restore Heading component secondary color styling (regression in v10.2.2) #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
Merged

Fix: Restore Heading component secondary color styling (regression in v10.2.2) #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e18c34e
Initial plan
Copilot Oct 9, 2025
d4ca49e
Fix Heading component styles not being applied
Copilot Oct 9, 2025
6d7af9b
Add changeset for heading color fix at patch level
Copilot Oct 9, 2025
e49d253
Update changeset to use named color instead of hex code
Copilot Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-heading-secondary-color.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"spectacle": patch
---

Fix Heading component not applying secondary color styling. Restores correct theme color for headings that was lost in v10.2.2 when replacing defaultProps with attrs method.
5 changes: 5 additions & 0 deletions packages/spectacle/src/components/typography.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ describe('<Heading />', () => {
const { getByText } = mountWithTheme(<Heading>Spectacle!</Heading>);
expect(getByText('Spectacle!')).toHaveStyle({ fontSize: 'h1' });
});

it('should apply the secondary color from theme', () => {
const { getByText } = mountWithTheme(<Heading>Spectacle!</Heading>);
expect(getByText('Spectacle!')).toHaveStyle({ color: '#fc6986' });
});
});

describe('<Quote />', () => {
Expand Down
5 changes: 3 additions & 2 deletions packages/spectacle/src/components/typography.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,16 @@ const Link = styled.a.attrs<CommonTypographyProps & DecorationProps>(
compose(color, typography, space, decoration)
);

const Heading = styled(Text).attrs<CommonTypographyProps>((props) => ({
const Heading = styled.div.attrs<CommonTypographyProps>((props) => ({
color: 'secondary',
fontFamily: 'header',
fontSize: 'h1',
fontWeight: 'bold',
textAlign: 'center',
margin: 1,
padding: 0,
...props
}))<CommonTypographyProps>({});
}))<CommonTypographyProps>(compose(color, typography, space));

const Quote = styled(
Text as FC<
Expand Down