Add tests for Issue #3473

Author: ScottDugas

fdb-relational-jdbc/src/test/java/com/apple/foundationdb/relational/jdbc/JDBCAutoCommitTest.java

@@ -69,7 +69,7 @@ public void tearDown() throws Exception {
      * Run a test with the default (auto-commit on) for sanity.
      */
     @Test
-    void autoCommitOn() throws SQLException, IOException {
+    void autoCommitOn() throws SQLException {
         try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
             try (RelationalStatement statement = connection.createStatement()) {
                 insertOneRow(statement);
@@ -80,6 +80,65 @@ void autoCommitOn() throws SQLException, IOException {
         }
     }
 
+    @Test
+    void autoCommitWithNoTransactionInBetween() throws SQLException {
+        try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
+            connection.setAutoCommit(false);
+            connection.setAutoCommit(true);
+        }
+    }
+
+    @Test
+    void autoCommitStayOn() throws SQLException {
+        try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
+            connection.setAutoCommit(true);
+        }
+    }
+
+    @Test
+    void autoCommitStayOff() throws SQLException {
+        try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
+            connection.setAutoCommit(false);
+            connection.setAutoCommit(false);
+        }
+    }
+
+    @Test
+    void commitEnableAutoCommit() throws SQLException {
+        try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
+            connection.setAutoCommit(false);
+
+            try (RelationalStatement statement = connection.createStatement()) {
+                insertOneRow(statement);
+            }
+            connection.commit();
+            connection.setAutoCommit(true);
+            try (RelationalStatement statement = connection.createStatement()) {
+                RelationalResultSet resultSet = statement.executeQuery("SELECT * FROM test_table");
+                assertNextResult(resultSet, 100, "one hundred");
+                assertNoNextResult(resultSet);
+            }
+        }
+    }
+
+    @Test
+    void rollbackThenEnableAutoCommit() throws SQLException {
+        try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
+            connection.setAutoCommit(false);
+
+            try (RelationalStatement statement = connection.createStatement()) {
+                insertOneRow(statement);
+            }
+            connection.rollback();
+            connection.setAutoCommit(true);
+            try (RelationalStatement statement = connection.createStatement()) {
+                RelationalResultSet resultSet = statement.executeQuery("SELECT * FROM test_table");
+                assertNoNextResult(resultSet);
+                assertNoNextResult(resultSet);
+            }
+        }
+    }
+
     /**
      * Run a test with commit and then read.
      */