address comments

Author: g31pranjal

fdb-relational-core/src/main/antlr/RelationalParser.g4

@@ -913,10 +913,6 @@ expressionOrDefault
     : expression | DEFAULT
     ;
 
-expressionWithName
-    : expression AS uid
-    ;
-
 expressionWithOptionalName
     : expression (AS uid)?
     ;

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/ddl/RecordLayerCatalogQueryFactory.java

@@ -65,7 +65,7 @@ public Type getResultSetMetadata() {
             public RelationalResultSet executeAction(Transaction txn) throws RelationalException {
                 final Schema schema = catalog.loadSchema(txn, dbId, schemaId);
 
-                final List<String> tableNames = schema.getTables().stream().map(Metadata::getName).map(DataTypeUtils::toProtoBufCompliantName)
+                final List<String> tableNames = schema.getTables().stream().map(Metadata::getName).map(DataTypeUtils::toUserIdentifier)
                         .collect(Collectors.toList());
 
                 final List<String> indexNames = schema.getTables().stream().flatMap(t -> t.getIndexes().stream()).map(Metadata::getName)

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/Identifier.java

@@ -74,11 +74,6 @@ public static Identifier of(@Nonnull String name, @Nonnull Iterable<String> qual
         return new Identifier(name, qualifier);
     }
 
-    @Nonnull
-    public Identifier withName(@Nonnull String name) {
-        return Identifier.of(name, qualifier);
-    }
-
     @Nonnull
     public Identifier withQualifier(@Nonnull Collection<String> qualifier) {
         if (qualifier.isEmpty()) {

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/BaseVisitor.java

@@ -1341,12 +1341,6 @@ public Object visitExpressionOrDefault(@Nonnull RelationalParser.ExpressionOrDef
         return visitChildren(ctx);
     }
 
-    @Nonnull
-    @Override
-    public Expression visitExpressionWithName(@Nonnull RelationalParser.ExpressionWithNameContext ctx) {
-        return expressionVisitor.visitExpressionWithName(ctx);
-    }
-
     @Nonnull
     @Override
     public Expression visitExpressionWithOptionalName(@Nonnull RelationalParser.ExpressionWithOptionalNameContext ctx) {

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/DelegatingVisitor.java

@@ -1189,12 +1189,6 @@ public Object visitExpressionOrDefault(@Nonnull RelationalParser.ExpressionOrDef
         return getDelegate().visitExpressionOrDefault(ctx);
     }
 
-    @Nonnull
-    @Override
-    public Expression visitExpressionWithName(@Nonnull RelationalParser.ExpressionWithNameContext ctx) {
-        return getDelegate().visitExpressionWithName(ctx);
-    }
-
     @Nonnull
     @Override
     public Expression visitExpressionWithOptionalName(@Nonnull RelationalParser.ExpressionWithOptionalNameContext ctx) {

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/ExpressionVisitor.java

@@ -625,14 +625,6 @@ public Expression visitMathExpressionAtom(@Nonnull RelationalParser.MathExpressi
         return getDelegate().resolveFunction(ctx.mathOperator().getText(), left, right);
     }
 
-    @Nonnull
-    @Override
-    public Expression visitExpressionWithName(@Nonnull RelationalParser.ExpressionWithNameContext ctx) {
-        final var expression = Assert.castUnchecked(ctx.expression().accept(this), Expression.class);
-        final var name = Identifier.toProtobufCompliant(visitUid(ctx.uid()));
-        return expression.withName(name);
-    }
-
     @Nonnull
     @Override
     public Expression visitExpressionWithOptionalName(@Nonnull RelationalParser.ExpressionWithOptionalNameContext ctx) {

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/TypedVisitor.java

@@ -742,10 +742,6 @@ public interface TypedVisitor extends RelationalParserVisitor<Object> {
     @Override
     Object visitExpressionOrDefault(@Nonnull RelationalParser.ExpressionOrDefaultContext ctx);
 
-    @Nonnull
-    @Override
-    Expression visitExpressionWithName(@Nonnull RelationalParser.ExpressionWithNameContext ctx);
-
     @Nonnull
     @Override
     Expression visitExpressionWithOptionalName(@Nonnull RelationalParser.ExpressionWithOptionalNameContext ctx);