Fix gradle 9 warnings and bump antlr version #3354
Conversation
arnaud-lacurie
added
cleanup
| @@ -198,7 +198,7 @@ public void decodeTerm(DataInput in, FieldInfo fieldInfo, BlockTermState _termSt | |||
| } else { | |||
| assert absolute == false; | |||
| assert termState.singletonDocID != -1; | |||
| termState.singletonDocID += BitUtil.zigZagDecode(l >>> 1); | |||
| termState.singletonDocID += (int)BitUtil.zigZagDecode(l >>> 1); | |||
There was a problem hiding this comment.
This seems fine to me. The only concern is that this class is borrowed from Lucene, and so making a modification here may make it harder to merge in changes from upstream
| @@ -69,7 +69,7 @@ private static BigInteger toIndex(int numBits, long... transposedIndexes) { | |||
| for (int i = 0; i < numBits; i++) { | |||
| for (final long transposedIndex : transposedIndexes) { | |||
| if ((transposedIndex & mask) != 0) { | |||
| b[b.length - 1 - bIndex / 8] |= 1 << (bIndex % 8); | |||
| b[b.length - 1 - bIndex / 8] |= (byte)(1 << (bIndex % 8)); | |||
There was a problem hiding this comment.
I'm confused how this change relates to Gradle 9. Looking at the logs, there still seem to be a bunch of gradle warnings, and no changes in this PR to fix the gradle files. Meanwhile #3358 Seems to be tackling a similar goal, and has no changes to the java code.
It also seems better to split the gradle 9 warning changes, and the antlr upgrade into separate PRs.
There was a problem hiding this comment.
I actually hit this also and decided not to address it in #3358: this change is about upgrading the JDK, not Gradle. If you compile with JDK23 from main, these show up today.
No description provided.