Implement a closeAll utility to close multiple closeables

[ohadzeliger]

Tech debt from the ThrottlingIterator work. Close multiple closeables and capture all exceptions.
Resolve #3465

[ScottDugas]

Why create a new exception type to accumulate, rather than setting it to the first exception thrown?

[ohadzeliger]

That was how I initially tried to implement this but the compiler complained about "close() method can throw InterruptedException" when the close() declares to throw Exception.
Similar to the issue described here: TritonDataCenter/java-manta#322

[ScottDugas]

Why the change here?

[ohadzeliger]

I thought this would be a better fit to a usage like:

    RepairValidationResults repairResults;
    try (RecordRepairValidateRunner repairRunner = builder.buildRepairRunner(false)) {
        repairResults = repairRunner.run().join();
    }
    // Handle results

Where a failure to close would disrupt the flow and cause the loss of already collected results.
But I am not too strongly opinionated about this.

[ScottDugas]

This seems only tangentially related to the purpose of the PR.

Also, I'm not sure I agree, I think you would want to do:

RepairValidationResults repairResults;
    try (RecordRepairValidateRunner repairRunner = builder.buildRepairRunner(false)) {
        repairResults = repairRunner.run().join();
        // handle results
    }

[ohadzeliger]

Reverted to previous behavior. Also, since CloseException is now declared on the signature of the method, I moved the exception to its own top level class.

[ScottDugas]

Suggested change

	* Exception thrown when the {@link CloseableUtils#closeAll} method catches an exception.
	* Exception thrown when the {@link #closeAll} method catches an exception.

[ohadzeliger]

Exception moved to separate file.

[ScottDugas]

Javadoc would be good, something short and sweet, like

Suggested change

	public class CloseableUtils {
	/**
	* Utility methods to help interact with {@link AutoCloseable} things.
	**/
	public class CloseableUtils {

[ScottDugas]

Also, an API annotation. INTERNAL I think.

[ohadzeliger]

Done x2

[ScottDugas]

This seems only tangentially related to the purpose of the PR.

Also, I'm not sure I agree, I think you would want to do:

RepairValidationResults repairResults;
    try (RecordRepairValidateRunner repairRunner = builder.buildRepairRunner(false)) {
        repairResults = repairRunner.run().join();
        // handle results
    }

[ScottDugas]

Since you are catch a generic exception, you are supposed to re-interrupt the current thread.

Also, probably worth a comment in the code here similar to the one on the PR explaining why we are converting it to a CloseException

[ohadzeliger]

Done. I think there could be no case of InterruptedException thrown from a close(), but it doesn't hurt to add a catch block.