Allow enabling autoCommit without an active transaction #3477
Conversation
This allows the server to figure out whether to commit or not
| TransactionalRequest.Builder transactionRequest = TransactionalRequest.newBuilder() | ||
| .setEnableAutoCommitRequest(EnableAutoCommitRequest.newBuilder().build()); | ||
| // wait here for response | ||
| final TransactionalResponse response = serverConnection.sendRequest(transactionRequest.build()); |
There was a problem hiding this comment.
Just to clarify: This request will always be sent prior to closing the stateful connection, and so (for the time being) can be considered an equivalent of "connection about to be orderly closed", right?
It is feasible that in the future we will use this same request to signify the change to the state of the connection (since I think we will change the protocol to be only using the "stateful" path to better sync the state of the connection between client and server).
| connection.commit(); | ||
| connection.setAutoCommit(true); | ||
| try (RelationalStatement statement = connection.createStatement()) { | ||
| RelationalResultSet resultSet = statement.executeQuery("SELECT * FROM test_table"); |
There was a problem hiding this comment.
Maybe this would be more exhaustive with another insert after the setAutoCommit(true)?
| @@ -371,6 +371,16 @@ public void transactionalRollback(TransactionalToken token) throws SQLException | |||
| token.getConnection().rollback(); | |||
| } | |||
|
|
|||
| public void enableAutoCommit(TransactionalToken token) throws SQLException { | |||
| // we don't actually call setAutoCommit(false) until an operation happens, so if there is no token | |||
There was a problem hiding this comment.
I think that - aligning this towards the future, where the client connection state will be in sync with the server-side connection state (TransactionalRequestHandler) - the logic of looking at the token should reside in the TransactionalRequestHandler.
FRL would be a simpler, stateless pass through to the EmbeddedConnection.
This changes the client so that it sends a request to enable autoCommit when it is enabled on the client, rather than calling
commitdirectly. By doing so, the server can determine whether it wants to commit or not based on whether it has an active transaction.Fixes: #3473