Skip to content

Add test to verify that temp functions are created in TxnBound database #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

g31pranjal
Copy link
Member

@g31pranjal g31pranjal commented Jul 16, 2025

This PR replaces the NoOpMetadataOperationsFactory passed in TransactionBoundSchemaTemplate with an implementation of MetadataOperationsFactory that supports getCreateFunctionConstantAction in the same way as it is supported by the RecordLayerMetadataOperationsFactory.

Also adds the test to verify that the TEMPORARY FUNCTION is actually available in the txn-bound schema template in the case when the Transaction is externally provided to the connection.

fixes #3489

@g31pranjal g31pranjal changed the title Add test to verify that temp functions are created in Txn-bound datab… Add test to verify that temp functions are created in TxnBound database Jul 16, 2025
@g31pranjal g31pranjal added enhancement New feature or request bug fix Change that fixes a bug relational issues related to relational FDB labels Jul 16, 2025
Copy link
Contributor

@hatyo hatyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

g31pranjal and others added 2 commits July 17, 2025 12:04
…ional/recordlayer/TransactionBoundDatabaseTest.java

Co-authored-by: Youssef Hatem <y_hatem@apple.com>
@g31pranjal g31pranjal merged commit 5f00885 into FoundationDB:main Jul 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Change that fixes a bug enhancement New feature or request relational issues related to relational FDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE FUNCTION does not work with TransactionBoundDatabase
2 participants